chore: Fix a couple broken book links #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@komaeda what would the |
|
|
|
☔ The latest upstream changes (presumably #174) made this pull request unmergeable. Please resolve the merge conflicts. |
miller-time
force-pushed
the
fix-book-links
branch
from
60e8599 to
e4f5b0b
Compare
miller-time
changed the title
miller-time
force-pushed
the
fix-book-links
branch
from
e4f5b0b to
63c133e
Compare
|
@bors: r+ |
|
📌 Commit 63c133e has been approved by |
bors
added
S-waiting-on-bors
and removed
S-waiting-on-author
bors
added a commit
that referenced
this pull request
Jun 23, 2019
chore: Fix a couple broken book links While I was fixing these, I figured maybe it's good to just use a consistent URL for book links: https://doc.rust-lang.org/book/ Is there a plan for what to do with this old 1.4.0 example that doesn't exist in the current version of the book? Perhaps at least include a disclaimer when recommending that folks check it out? https://github.com/rust-lang/rustlings/blob/34e31232dfddde284a341c9609b33cd27d9d5724/exercises/threads/README.md#L1
|
☀️ Test successful - checks-travis |
ppp3
pushed a commit
to ppp3/rustlings
that referenced
this pull request
May 23, 2022
chore: Fix a couple broken book links While I was fixing these, I figured maybe it's good to just use a consistent URL for book links: https://doc.rust-lang.org/book/ Is there a plan for what to do with this old 1.4.0 example that doesn't exist in the current version of the book? Perhaps at least include a disclaimer when recommending that folks check it out? https://github.com/rust-lang/rustlings/blob/34e31232dfddde284a341c9609b33cd27d9d5724/exercises/threads/README.md#L1
dmoore04
pushed a commit
to dmoore04/rustlings
that referenced
this pull request
Sep 11, 2022
chore: Fix a couple broken book links While I was fixing these, I figured maybe it's good to just use a consistent URL for book links: https://doc.rust-lang.org/book/ Is there a plan for what to do with this old 1.4.0 example that doesn't exist in the current version of the book? Perhaps at least include a disclaimer when recommending that folks check it out? https://github.com/rust-lang/rustlings/blob/4a6c4754c684a2c7ee757e8bccf9955f92ef6dab/exercises/threads/README.md#L1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was fixing these, I figured maybe it's good to just use a consistent URL for book links: https://doc.rust-lang.org/book/
Is there a plan for what to do with this old 1.4.0 example that doesn't exist in the current version of the book? Perhaps at least include a disclaimer when recommending that folks check it out?
rustlings/exercises/threads/README.md
Line 1 in 34e3123