Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(ci): Now github should also check if the nix dev-env/buil… #1651

Closed
wants to merge 2 commits into from

Conversation

x10an14
Copy link
Contributor

@x10an14 x10an14 commented Aug 30, 2023

…d breaks

@x10an14 x10an14 marked this pull request as draft August 30, 2023 16:31
@x10an14
Copy link
Contributor Author

x10an14 commented Aug 30, 2023

Depends on #1650

@shadows-withal shadows-withal added the S-waiting-on-author Status: Waiting on issue/PR author label Sep 4, 2023
@x10an14 x10an14 marked this pull request as ready for review September 4, 2023 11:53
So as to not overflow UI elements on github.com/rust-lang/rustlings/actions

Co-authored-by: liv <[email protected]>
@x10an14
Copy link
Contributor Author

x10an14 commented Sep 4, 2023

Needs some debugging/fixing as to why the x86_64-linux experience on multiple private machines, break on the Ubuntu Github Actions build envs.

Any help from others to test the nix commands that fail is very welcome.

@shadows-withal shadows-withal added E-help-wanted and removed S-waiting-on-author Status: Waiting on issue/PR author labels Sep 4, 2023
@markgreene74
Copy link
Contributor

hi @x10an14 I gave your workflow a try, and this is what I found:

nix-build-and-run-rustlings

The nix-build-and-run-rustlings job seems to fail because of the rustc version.

Error:

> error: package `clap_derive v4.4.2` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.64.0

The error does not happen if I try a new build. I guess the rustc version was maybe bumped up in the Nix build.

Here is the link to a successful run with the --debug flag: nix-build-and-run-rustlings

copying path '/nix/store/66a3ip9miaimi7gyhl6jdzbjchp76ccv-rustc-1.72.0' from 'https://cache.nixos.org/'...
locking path '/nix/store/66a3ip9miaimi7gyhl6jdzbjchp76ccv-rustc-1.72.0'
lock acquired on '/nix/store/66a3ip9miaimi7gyhl6jdzbjchp76ccv-rustc-1.72.0.lock'

So this seems OK now.

nix-dev-shell

The nix-dev-shell job fails with this error:

error: flake output attribute 'devShell' is not a derivation or path

I am not very good with Nix but looking at the flake.nix file and the Flake docs here and here the error makes sense, as it doesn't look like devShell is defined as packages."<system>"."<name>".

If I replace nix build .#devShell with nix build .#rustlings-app instead I get this different error:

error: flake 'git+file:///home/runner/work/rustlings/rustlings?shallow=1' does not provide attribute 'packages.x86_64-linux.rustlings-app', 'legacyPackages.x86_64-linux.rustlings-app' or 'rustlings-app'

I did some additional testing in this branch if anybody is interested in seeing the results: https://github.com/markgreene74/rustlings/tree/test/x10an14-fork-add-nix-github-workflow

@mo8it
Copy link
Contributor

mo8it commented Apr 1, 2024

Closing because of missing response. Things will change in v6 anyway so we probably need something else then.

@mo8it mo8it closed this Apr 1, 2024
@x10an14
Copy link
Contributor Author

x10an14 commented Apr 1, 2024

Apologies for missing the message you expected a response to. What are the plans for v6? Where/what issue/PR can I read up on them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants