-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement(ci): Now github should also check if the nix dev-env/buil… #1651
Conversation
Depends on #1650 |
So as to not overflow UI elements on github.com/rust-lang/rustlings/actions Co-authored-by: liv <[email protected]>
Needs some debugging/fixing as to why the x86_64-linux experience on multiple private machines, break on the Ubuntu Github Actions build envs. Any help from others to test the nix commands that fail is very welcome. |
hi @x10an14 I gave your workflow a try, and this is what I found: nix-build-and-run-rustlingsThe Error:
The error does not happen if I try a new build. I guess the Here is the link to a successful run with the
So this seems OK now. nix-dev-shellThe nix-dev-shell job fails with this error:
I am not very good with Nix but looking at the If I replace
I did some additional testing in this branch if anybody is interested in seeing the results: https://github.com/markgreene74/rustlings/tree/test/x10an14-fork-add-nix-github-workflow |
Closing because of missing response. Things will change in v6 anyway so we probably need something else then. |
Apologies for missing the message you expected a response to. What are the plans for v6? Where/what issue/PR can I read up on them? |
…d breaks