Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test1.rs doesn't adhere to naming conventions #180

Closed
Masterhigure opened this issue Jun 23, 2019 · 0 comments · Fixed by #184
Closed

test1.rs doesn't adhere to naming conventions #180

Masterhigure opened this issue Jun 23, 2019 · 0 comments · Fixed by #184

Comments

@Masterhigure
Copy link

In the exercise file test1.rs, there is a function named calculateprice. Standard Rust naming conventions requires it to be named calculate_price, using snake case.
Jesse-Cameron added a commit to Jesse-Cameron/rustlings that referenced this issue Jun 28, 2019
@Jesse-Cameron
fix(test1): renamed function name to snake case
89d5186 
closes rust-lang#180
@Jesse-Cameron Jesse-Cameron mentioned this issue Jun 28, 2019
Merged
bors added a commit that referenced this issue Jun 28, 2019
@bors
Auto merge of #184 - Jesse-Cameron:master, r=komaeda
5e1d7c3 
fix(test1): renamed function name to snake case

addressing a minor function naming convention, see: [RFC #430](https://doc.rust-lang.org/1.0.0/style/style/naming/README.html)

closes #180
@bors bors closed this as completed in #184 Jun 28, 2019
pedantic79 pushed a commit to pedantic79/rustlings that referenced this issue Apr 11, 2020
@Jesse-Cameron
fix(test1): renamed function name to snake case
72dcc74 
closes rust-lang#180
pedantic79 pushed a commit to pedantic79/rustlings that referenced this issue Apr 11, 2020
@bors
Auto merge of rust-lang#184 - Jesse-Cameron:master, r=komaeda
4d20772 
fix(test1): renamed function name to snake case

addressing a minor function naming convention, see: [RFC rust-lang#430](https://doc.rust-lang.org/1.0.0/style/style/naming/README.html)

closes rust-lang#180
ppp3 pushed a commit to ppp3/rustlings that referenced this issue May 23, 2022
fix(test1): renamed function name to snake case
5bd1692 
closes rust-lang#180
ppp3 pushed a commit to ppp3/rustlings that referenced this issue May 23, 2022
Auto merge of rust-lang#184 - Jesse-Cameron:master, r=komaeda
fbb77e4 
fix(test1): renamed function name to snake case

addressing a minor function naming convention, see: [RFC rust-lang#430](https://doc.rust-lang.org/1.0.0/style/style/naming/README.html)

closes rust-lang#180
dmoore04 pushed a commit to dmoore04/rustlings that referenced this issue Sep 11, 2022
@Jesse-Cameron
fix(test1): renamed function name to snake case
3ae9af8 
closes rust-lang#180
dmoore04 pushed a commit to dmoore04/rustlings that referenced this issue Sep 11, 2022
@bors
Auto merge of rust-lang#184 - Jesse-Cameron:master, r=komaeda
0c9a3c9 
fix(test1): renamed function name to snake case

addressing a minor function naming convention, see: [RFC rust-lang#430](https://doc.rust-lang.org/1.0.0/style/style/naming/README.html)

closes rust-lang#180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(test1): renamed function name to snake case Jesse-Cameron/rustlings
1 participant
@Masterhigure