Bump rustc-ap crates #4817
Merged
Bump rustc-ap crates #4817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also requires bumping the nightly toolchain version, since the latest versions of the rustc-ap crates require some new nightly features.
calebcartwright
approved these changes
Apr 28, 2021
There was a problem hiding this comment.
Thanks!
Unrelated side notes 😄 First, congrats on becoming a full compiler team member, well deserved! Second, I forget which exact PRs they were, but there were a couple PRs in r-l/rust a little while back where you pinged us to give us a heads up about some changes that would impact us, and just wanted to say thank you. That was tremendously helpful and allowed me get in front of a few other upstream changes prior to a nightly toolstate breakage ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.