v1.4.30 backport of bounds indentation issue #4653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The i686 windows failures are unrelated linking issues that were caused by GitHub changing the MSYS/MinGW locations on PATH which we've subsequently fixed in the Actions workflow files. Not going to bother backporting those yaml file modifications here though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was reported (#4636) that currently exists in the rustfmt version on beta (1.4.30) which has been fixed in rustfmt v1.4.32. We need to get this fixed to avoid shipping a known bug on stable, but we cannot readily do the typical roll-forward approach due to conflicting needs in the rustc-ap crates that had to be bumped between those two rustfmt versions (refs rust-lang/rust#81151 (comment))
Instead, cherry-picking these commits that fixed the bug back onto the rustfmt 1.4.30 branch so the bug fix can still be pulled in for the 1.50 release