Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x: Bump rustc-ap to v679 #4434

Merged
merged 3 commits into from
Sep 23, 2020
Merged

1.x: Bump rustc-ap to v679 #4434

merged 3 commits into from
Sep 23, 2020

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Sep 23, 2020

This is a backport of #4423 and #4433.

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will merge this once the PR checks finish but probably still a little ways out from pushing v1.4.22 to nightly. Is this something needed urgently in rustfmt 1.x release?

@dtolnay
Copy link
Member Author

dtolnay commented Sep 23, 2020

I just want to be sure that unsafe mod works with the rustfmt that ships with the rustc release which first supports it. Otherwise it would block me from being able to require the syntax in code downstream of https://github.com/dtolnay/cxx for an unnecessary additional release cycle.

@calebcartwright
Copy link
Member

I just want to be sure that unsafe mod works with the rustfmt that ships with the rustc release which first supports it.

Gotcha. I'll go ahead and start the process in that case, although as you may already know, rustc-ap bumps have to be coordinated and sequenced across several different repos (racer and RLS as well as here) so can't necessarily make any guarantees

@calebcartwright calebcartwright merged commit 146578c into rust-lang:rustfmt-1.4.22 Sep 23, 2020
@dtolnay dtolnay deleted the backport branch September 23, 2020 05:46
@calebcartwright
Copy link
Member

Now that the corresponding version of racer has been released I'll run our release here and open a PR in RLS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants