Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor to use param naming where appropriate #3803

Merged
merged 2 commits into from
Sep 24, 2019
Merged

refactor to use param naming where appropriate #3803

merged 2 commits into from
Sep 24, 2019

Conversation

calebcartwright
Copy link
Member

Resolves #3801

@calebcartwright
Copy link
Member Author

calebcartwright commented Sep 22, 2019 •
edited
Loading

As part of 2.x, we may also want to see whether we should augment/rename any config options, for example: should https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#fn_args_layout probably be fn_params_layout? Or should there be one option for params in a function signature, and another for args on calls?

@topecongiro topecongiro merged commit 9c2b375 into rust-lang:master Sep 24, 2019
@topecongiro
Copy link
Contributor

As part of 2.x, we may also want to see whether we should augment/rename any config options, for example: should https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#fn_args_layout probably be fn_params_layout? Or should there be one option for params in a function signature, and another for args on calls?

Yeah, I think renaming it on bumping to 2.0 sounds good.

@calebcartwright calebcartwright deleted the param-vs-arg branch September 24, 2019 00:47
@calebcartwright calebcartwright mentioned this pull request May 1, 2020
Closed
@ytmimi ytmimi mentioned this pull request Nov 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Param vs. Arg naming
2 participants
@calebcartwright @topecongiro