-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create bench_cmp
command
#1955
Create bench_cmp
command
#1955
Conversation
72fcfc0
to
671a368
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this! :) I would like to avoid one big PR that will implement some super-duper UI at once, so let's first land the basic CLI interface, and just output a single useful piece of information (which compiler is faster on instruction counts on average, and by how much). Then you can improve the UI incrementally piece by piece.
To clarify: even though I suggested just to output a simple text line for simplicity, you can keep the table that you have right now, if you want. Although I suppose that soon it will be replaced by a more complex UI anyway. |
d20abeb
to
a4a51f4
Compare
Thanks! I've fixed the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's really cool to be able to just run a CLI command and instantly see the difference :) This is gonna be very useful. Left a few more comments.
10a6472
to
6bc5839
Compare
This comment was marked as outdated.
This comment was marked as outdated.
85f7578
to
0e04b34
Compare
0e04b34
to
383b3c2
Compare
3dc4ea8
to
9189a3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Tried it locally and it works great. Thank you!
I've implemented a small example command for comparing two artifacts. Currently, it only displays the range, mean, and count across all series. This is the first step towards #1734. I'm not sure if the way I'm collecting data is correct or not.