Add basic steps for a new target #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
reviewed
Jul 19, 2020
androm3da
reviewed
Jul 20, 2020
| # that we're shipping as well (to ensure that the rustfmt in RLS and the | ||
| # `rustfmt` executable are the same exact version). | ||
| rustfmt-nightly = { path = "src/tools/rustfmt" } | ||
| +libc = { git = "https://github.com/rust-lang/libc", rev = "0bf7ce340699dcbacabdf5f16a242d2219a49ee0" } |
There was a problem hiding this comment.
Is it possible to describe when or why you might want to patch the libc used by the top-level Cargo.toml versus situations where you'd patch the libc dependency of rustc-std-workspace-{std,core,alloc} (assuming there are some)?
There was a problem hiding this comment.
It may be possible, but I don't know the reason. I only needed to patch the listed Cargo.toml.
jyn514
approved these changes
Jul 28, 2020
|
Yeah, this is a weird failure. I restarted CI... |
JohnTitor
reviewed
Jul 28, 2020
src/building/new-target.md
Outdated
| # See comments in `src/tools/rustc-workspace-hack/README.md` for what's going on | ||
| # here | ||
| rustc-workspace-hack = { path = 'src/tools/rustc-workspace-hack' } | ||
| ``` |
There was a problem hiding this comment.
This one white-space before the fence confuses our line length checker :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.