Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add section on overlap checks #2042

Merged
merged 4 commits into from
Sep 6, 2024
Merged

add section on overlap checks #2042

merged 4 commits into from
Sep 6, 2024

Conversation

jdonszelmann
Copy link
Contributor

Added a section on overlap checks after talking with @lcnr

lcnr
lcnr reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move the chapter Type checking and rename it to the more general "Coherence checking". Talking about overlap checking outside of coherence feels like it may lead to the wrong impression.

src/traits/overlap.md Outdated Show resolved Hide resolved
src/traits/overlap.md Outdated Show resolved Hide resolved
src/traits/overlap.md Outdated Show resolved Hide resolved
@jdonszelmann
Copy link
Contributor Author

I didn't know too much more to say specifically on the orphan check, maybe that's not needed as much either. However, I did put it in the broader context of coherence checking (and it's now moved under type checking)

@jdonszelmann jdonszelmann requested a review from lcnr August 13, 2024 09:56
lcnr
lcnr reviewed Sep 6, 2024
View reviewed changes
src/coherence.md Outdated Show resolved Hide resolved
src/coherence.md Outdated Show resolved Hide resolved
lcnr
lcnr reviewed Sep 6, 2024
View reviewed changes
src/coherence.md Outdated Show resolved Hide resolved
lcnr
lcnr reviewed Sep 6, 2024
View reviewed changes
src/coherence.md Outdated Show resolved Hide resolved
@lcnr lcnr enabled auto-merge (squash) September 6, 2024 14:03
@lcnr lcnr merged commit 75ffaf0 into rust-lang:master Sep 6, 2024
1 check passed
@rustbot rustbot mentioned this pull request Sep 9, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 9, 2024
@matthiaskrgr
Rollup merge of rust-lang#130158 - rustbot:docs-update, r=ehuss
a0346bb 
Update books

## rust-lang/edition-guide

1 commits in eeba2cb9c37ab74118a4fb5e5233f7397e4a91f8..b3ca7ade0f87d7e3fb538776defc5b2cc4188172
2024-09-03 22:59:56 UTC to 2024-09-03 22:59:56 UTC

- Rename `static_mut_refs` file to plural

## rust-embedded/book

1 commits in ff5d61d56f11e1986bfa9652c6aff7731576c37d..dbae36bf3f8410aa4313b3bad42e374735d48a9d
2024-09-04 20:49:11 UTC to 2024-09-04 20:49:11 UTC

- Fix small error in c bindings (rust-embedded/book#377)

## rust-lang/reference

6 commits in 0668397076da350c404dadcf07b6cbc433ad3743..687faf9958c52116d003b41dfd29cc1cf44f5311
2024-09-03 20:21:23 UTC to 2024-08-29 01:11:29 UTC

- `asm!`: clarify that `nomem` / `readonly` can access private memory (rust-lang/reference#1598)
- Switch warning blocks to use admonitions (rust-lang/reference#1595)
- dont use stdcall on x86_64 where it is not a valid ABI (rust-lang/reference#1600)
- Add capturing and precise capturing rules (rust-lang/reference#1577)
- Add a prefix to rule HTML IDs (rust-lang/reference#1593)
- Add a description of rule identifiers (rust-lang/reference#1594)

## rust-lang/rust-by-example

2 commits in 859786c5bc99301bbc22fc631a5c2b341860da08..c79ec345f08a1e94494cdc8c999709a90203fd88
2024-09-08 13:24:48 UTC to 2024-09-08 13:24:08 UTC

- Fix typo in conversion/from_into (rust-lang/rust-by-example#1882)
- Corrected x values for example rectangle (rust-lang/rust-by-example#1884)

## rust-lang/rustc-dev-guide

9 commits in fa928a6d19e1666d8d811dfe3fd35cdad3b4e459..0ed9229f5b6f7824b333beabd7e3d5ba4b9bd971
2024-09-09 10:58:45 UTC to 2024-08-31 13:02:08 UTC

- fix some comments (rust-lang/rustc-dev-guide#2059)
- Fix a link and create an implied internal link  (rust-lang/rustc-dev-guide#2051)
- link to additional LLVM update PRs (rust-lang/rustc-dev-guide#2055)
- fix/improve rdg contributing howto (rust-lang/rustc-dev-guide#2056)
- fixed the typo (rust-lang/rustc-dev-guide#2058)
- fix typo maker -> marker (thanks `@lholten)` (rust-lang/rustc-dev-guide#2057)
- improve query system documentation (rust-lang/rustc-dev-guide#2041)
- add section on overlap checks (rust-lang/rustc-dev-guide#2042)
- clarify the role of rustc_const_unstable (rust-lang/rustc-dev-guide#2045)
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2024
@rust-timer
Unrolled build for rust-lang#130158
202dabf 
Rollup merge of rust-lang#130158 - rustbot:docs-update, r=ehuss

Update books

## rust-lang/edition-guide

1 commits in eeba2cb9c37ab74118a4fb5e5233f7397e4a91f8..b3ca7ade0f87d7e3fb538776defc5b2cc4188172
2024-09-03 22:59:56 UTC to 2024-09-03 22:59:56 UTC

- Rename `static_mut_refs` file to plural

## rust-embedded/book

1 commits in ff5d61d56f11e1986bfa9652c6aff7731576c37d..dbae36bf3f8410aa4313b3bad42e374735d48a9d
2024-09-04 20:49:11 UTC to 2024-09-04 20:49:11 UTC

- Fix small error in c bindings (rust-embedded/book#377)

## rust-lang/reference

6 commits in 0668397076da350c404dadcf07b6cbc433ad3743..687faf9958c52116d003b41dfd29cc1cf44f5311
2024-09-03 20:21:23 UTC to 2024-08-29 01:11:29 UTC

- `asm!`: clarify that `nomem` / `readonly` can access private memory (rust-lang/reference#1598)
- Switch warning blocks to use admonitions (rust-lang/reference#1595)
- dont use stdcall on x86_64 where it is not a valid ABI (rust-lang/reference#1600)
- Add capturing and precise capturing rules (rust-lang/reference#1577)
- Add a prefix to rule HTML IDs (rust-lang/reference#1593)
- Add a description of rule identifiers (rust-lang/reference#1594)

## rust-lang/rust-by-example

2 commits in 859786c5bc99301bbc22fc631a5c2b341860da08..c79ec345f08a1e94494cdc8c999709a90203fd88
2024-09-08 13:24:48 UTC to 2024-09-08 13:24:08 UTC

- Fix typo in conversion/from_into (rust-lang/rust-by-example#1882)
- Corrected x values for example rectangle (rust-lang/rust-by-example#1884)

## rust-lang/rustc-dev-guide

9 commits in fa928a6d19e1666d8d811dfe3fd35cdad3b4e459..0ed9229f5b6f7824b333beabd7e3d5ba4b9bd971
2024-09-09 10:58:45 UTC to 2024-08-31 13:02:08 UTC

- fix some comments (rust-lang/rustc-dev-guide#2059)
- Fix a link and create an implied internal link  (rust-lang/rustc-dev-guide#2051)
- link to additional LLVM update PRs (rust-lang/rustc-dev-guide#2055)
- fix/improve rdg contributing howto (rust-lang/rustc-dev-guide#2056)
- fixed the typo (rust-lang/rustc-dev-guide#2058)
- fix typo maker -> marker (thanks `@lholten)` (rust-lang/rustc-dev-guide#2057)
- improve query system documentation (rust-lang/rustc-dev-guide#2041)
- add section on overlap checks (rust-lang/rustc-dev-guide#2042)
- clarify the role of rustc_const_unstable (rust-lang/rustc-dev-guide#2045)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdonszelmann @lcnr