-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend debugging llvm section #1290
Merged
JohnTitor
merged 13 commits into
rust-lang:master
from
pnkfelix:extend-debugging-llvm-section
Apr 14, 2022
Merged
Extend debugging llvm section #1290
JohnTitor
merged 13 commits into
rust-lang:master
from
pnkfelix:extend-debugging-llvm-section
Apr 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat URL to point there.
(This is useful in part to provide *me* guidance about where I will add additional material...)
…g post that I had to include a link.
…hogonal to the point about the details of LLVM IR generated by rustc itself.
the now-adjacent "Get your hands on raw LLVM input" sections.
Oh no, line lengths! Will fix. |
camelid
added
C-section-review
Category: A review of a section that can be used to improve that section
S-waiting-on-review
Status: this PR is waiting for a reviewer to verify its content
and removed
C-section-review
Category: A review of a section that can be used to improve that section
labels
Jan 26, 2022
spastorino
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems great to me.
Merged in favor of the above approval, thanks! |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 21, 2022
Update books ## book 3 commits in 765318b844569a642ceef7bf1adab9639cbf6af3..de0dbffc5812fd885700874e8d258dd334733ac4 2022-04-12 21:14:47 -0400 to 2022-04-18 19:29:45 -0400 - Remove duplicate text - Add missing punctuation mark in ch16-01 - Update main.rs ## rust-by-example 1 commits in c2a98d9fc5d29c481d42052fbeccfde15ed03116..44a80e8d8bfc5881c9bd69a2cb3a570776ee4181 2022-04-08 06:44:18 -0300 to 2022-04-19 07:46:28 -0300 - Use rust 2018 module file hierarchy (rust-lang/rust-by-example#1532) ## rustc-dev-guide 6 commits in eeb5a83c15b6ae60df3e4f19207376b22c6fbc4c..043e60f4f191651e9f8bf52fa32df14defbb23d9 2022-04-11 23:29:48 +0900 to 2022-04-20 18:57:49 +0900 - Fix a small typo (rust-lang/rustc-dev-guide#1343) - Extend debugging llvm section (rust-lang/rustc-dev-guide#1290) - Send people doing *library* stabilizations over to the std-dev-guide (rust-lang/rustc-dev-guide#1317) - Fix typo serious->series (rust-lang/rustc-dev-guide#1336) - Minor type fix (rust-lang/rustc-dev-guide#1337) - sessiondiagnostic: translation (rust-lang/rustc-dev-guide#1333) ## embedded-book 3 commits in a6de8b6e3ea5d4f0de8b7b9a7e5c1405dc2c2ddb..f7cefbb995eec8c6148f213235e9e2e03268e775 2022-03-17 21:21:39 +0000 to 2022-04-20 10:38:51 +0000 - Fix use of unaligned references in example (rust-embedded/book#317) - Correct C interop declarations (rust-embedded/book#315) - Update index.md (rust-embedded/book#316)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a drive-by, I fixed some out of date stuff (e.g. point to the relatively new LLVM github repo to which they've migrated their issues).
But my main focus was on capturing things I learned or relearned over the past month or so.