Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment: testing cargo scrape-examples in Crater #99924

Closed
wants to merge 2 commits into from
Closed

Experiment: testing cargo scrape-examples in Crater #99924

wants to merge 2 commits into from

Conversation

willcrichton
Copy link
Contributor

This PR does NOT need a review. It is testing out a change to Cargo via Crater.

r? @ghost

@rustbot
Copy link
Collaborator

rustbot commented Jul 29, 2022

Some changes occurred in src/tools/cargo

cc @ehuss

@willcrichton
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented Jul 29, 2022

@willcrichton: 🔑 Insufficient privileges: not in try users

@ehuss
Copy link
Contributor

ehuss commented Jul 30, 2022

@bors try

@bors
Copy link
Contributor

bors commented Jul 30, 2022

⌛ Trying commit 44ef9a05cc5c8863c901297c7ee6a2dfafca29ea with merge 1ba6a9abbf4496fb3e97bbcc3284ea7d62e6349f...

@ehuss
Copy link
Contributor

ehuss commented Jul 30, 2022

@bors delegate+

@bors
Copy link
Contributor

bors commented Jul 30, 2022

✌️ @willcrichton can now approve this pull request

@bors
Copy link
Contributor

bors commented Jul 30, 2022

☀️ Try build successful - checks-actions
Build commit: 1ba6a9abbf4496fb3e97bbcc3284ea7d62e6349f (1ba6a9abbf4496fb3e97bbcc3284ea7d62e6349f)

@willcrichton
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented Jul 31, 2022

⌛ Trying commit cb2d7a8ecad2d610514e5a9d935938f5fdf3c2a7 with merge 339827f5fe28434bbdbb89cf0e3e531acf167554...

@bors
Copy link
Contributor

bors commented Jul 31, 2022

☀️ Try build successful - checks-actions
Build commit: 339827f5fe28434bbdbb89cf0e3e531acf167554 (339827f5fe28434bbdbb89cf0e3e531acf167554)

@willcrichton
Copy link
Contributor Author

@craterbot run name=scrape-examples-test start=nightly end=try#339827f5fe28434bbdbb89cf0e3e531acf167554+cargoflags=-Zrustdoc-scrape-examples mode=rustdoc crates=top-1000

@craterbot
Copy link
Collaborator

🔒 Error: you're not allowed to interact with this bot.

🔑 If you are a member of the Rust team and need access, add yourself to the whitelist.
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Dylan-DPC
Copy link
Member

@willcrichton do you still want to do this? if you can resolve the conflicts I can run the crater run on it

@willcrichton
Copy link
Contributor Author

@Dylan-DPC thanks for checking -- I've just been running Crater locally with the try-build from this PR. I'm going to leave this open until rust-lang/cargo#10343 is merged in case of further testing needs.

@Dylan-DPC
Copy link
Member

Cool marking it as blocked till then :P

@Dylan-DPC Dylan-DPC added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Nov 16, 2022
@willcrichton
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented Nov 25, 2022

⌛ Trying commit f8d12aeac851a5dd644f30ad9c4954ead485f6ed with merge ff1cf0447cc0fd7a196a58913d8607fc2ff46af0...

@bors
Copy link
Contributor

bors commented Nov 26, 2022

☀️ Try build successful - checks-actions
Build commit: ff1cf0447cc0fd7a196a58913d8607fc2ff46af0 (ff1cf0447cc0fd7a196a58913d8607fc2ff46af0)

@willcrichton
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented Nov 26, 2022

⌛ Trying commit f8d12aeac851a5dd644f30ad9c4954ead485f6ed with merge 5e88b88a8bfd027daedf6ea47b0b19810f4c188a...

@willcrichton
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented Nov 26, 2022

⌛ Trying commit eee75d4b3e107027daea56b4ec5ff1a2a330e8a3 with merge 8364ac5b08adbebe455445ae4e67ecaf4140227e...

@willcrichton
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented Dec 11, 2022

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout cargo-test (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self cargo-test --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message 
Failed to merge submodule src/tools/cargo (not checked out)
Auto-merging src/tools/cargo
CONFLICT (submodule): Merge conflict in src/tools/cargo
Auto-merging .gitmodules
Automatic merge failed; fix conflicts and then commit the result.

@willcrichton
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented Dec 11, 2022

⌛ Trying commit 23ddb83 with merge 6ee483316d2e4581572121d60a955affb2032eb3...

@bors
Copy link
Contributor

bors commented Dec 12, 2022

☀️ Try build successful - checks-actions
Build commit: 6ee483316d2e4581572121d60a955affb2032eb3 (6ee483316d2e4581572121d60a955affb2032eb3)

@willcrichton
Copy link
Contributor Author

@Dylan-DPC can I ask you to run a Crater job for me? Here's the experiment parameters:

name=scrape-examples start=nightly end=try#6ee483316d2e4581572121d60a955affb2032eb3+cargoflags=-Zrustdoc-scrape-examples mode=rustdoc

@Dylan-DPC
Copy link
Member

@craterbot name=scrape-examples start=nightly end=try#6ee483316d2e4581572121d60a955affb2032eb3+cargoflags=-Zrustdoc-scrape-examples mode=rustdoc

@craterbot
Copy link
Collaborator

🚨 Error: experiment 'scrape-examples' not found

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@willcrichton
Copy link
Contributor Author

@Dylan-DPC Oh sorry I meant to include a "run" at the beginning there 😅 so run:

@craterbot run name=scrape-examples start=nightly end=try#6ee483316d2e4581572121d60a955affb2032eb3+cargoflags=-Zrustdoc-scrape-examples mode=rustdoc

@craterbot
Copy link
Collaborator

🔒 Error: you're not allowed to interact with this bot.

🔑 If you are a member of the Rust team and need access, add yourself to the whitelist.
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Dylan-DPC
Copy link
Member

oh i was supposed to run run, forgot to type it before pasting what you'd sent :D

@Dylan-DPC
Copy link
Member

@craterbot run name=scrape-examples start=nightly end=try#6ee483316d2e4581572121d60a955affb2032eb3+cargoflags=-Zrustdoc-scrape-examples mode=rustdoc

@craterbot
Copy link
Collaborator

👌 Experiment scrape-examples created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. labels Dec 12, 2022
@craterbot
Copy link
Collaborator

🚧 Experiment scrape-examples is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment scrape-examples is completed!
📊 274 regressed and 1545 fixed (249932 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 13, 2022
@anden3
Copy link
Contributor

anden3 commented Apr 22, 2023

Hi @willcrichton! Since the experiment was successful, can this PR be closed? Or do you plan on using it more?

@anden3 anden3 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2023
@willcrichton
Copy link
Contributor Author

Yes I think we can go ahead and close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@willcrichton @rustbot @bors @ehuss @craterbot @Dylan-DPC @rust-log-analyzer @anden3