migrate some of rustc_passes::check_attr's diagnostics and derive improvements
#99213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
compiler-errors
approved these changes
Jul 14, 2022
davidtwco
force-pushed
the
translation-migrate-passes
branch
from
98362e3
to
505e7e7
Compare
|
@bors r=compiler-errors |
|
📌 Commit 505e7e7d94b3a168dad1c614cc2dfea76460b87a has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
This comment was marked as resolved.
This comment was marked as resolved.
bors
added
S-waiting-on-author
Implements `IntoDiagnosticArg` for `char` using its `Debug` implementation and introduces a macro for those types which just delegate the implementation to `ToString`. Signed-off-by: David Wood <[email protected]>
Apply the `#[rustc_lint_diagnostics]` attribute to `LintDiagnosticBuilder::build` so that diagnostic migration lints will trigger for it. Signed-off-by: David Wood <[email protected]>
Add support for `MultiSpan` with any of the attributes that work on a `Span` - requires that diagnostic logic generated for these attributes are emitted in the by-move block rather than the by-ref block that they would normally have been generated in. Signed-off-by: David Wood <[email protected]>
Both diagnostic and subdiagnostic derives were missing the ability to
add warnings to diagnostics - this is made more difficult by the `warn`
attribute already existing, so this name being unavailable for the
derives to use. `#[warn_]` is used instead, which requires
special-casing so that `{span_,}warn` is called instead of
`{span_,}warn_`.
Signed-off-by: David Wood <[email protected]>
Migrate half of the `rustc_passes::check_attr` diagnostics to using diagnostic derives and being translatable.
davidtwco
force-pushed
the
translation-migrate-passes
branch
from
505e7e7
to
78b19a9
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 16, 2022
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#98582 (Allow destructuring opaque types in their defining scopes) - rust-lang#99213 (migrate some of `rustc_passes::check_attr`'s diagnostics and derive improvements) - rust-lang#99258 (Provide structured suggestion for dropped temp value) - rust-lang#99259 (interpret/visitor: support visiting with a PlaceTy) - rust-lang#99287 ([rustdoc-json] JSON no longer inlines) - rust-lang#99290 (Revert "Highlight conflicting param-env candidates") - rust-lang#99316 (docs: add missing word) - rust-lang#99317 (Borrow Vec<T, A> as [T]) - rust-lang#99323 (Fix flakyness of GUI tests) - rust-lang#99342 (Avoid some `Symbol` to `String` conversions) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 27, 2022
…s-2, r=compiler-errors passes: port more of `check_attr` module Continues from rust-lang#99213. Port more diagnostics in `rustc_passes::check_attr` to using the diagnostic derive and translation machinery. r? `@compiler-errors`
compiler-errors
added
the
A-translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntoDiagnosticArgforcharusing itsDebugimplementation and introduces a macro for those types which just delegate the implementation toToString.#[rustc_lint_diagnostics]attribute toLintDiagnosticBuilder::buildso that diagnostic migration lints will trigger for it - some diagnostics inrustc_privacyneed updated after this since the lints apply to that crate.MultiSpanwith any of the attributes that work on aSpanin the diagnostic derive (SessionDiagnostic+LintDiagnostic). Requires that diagnostic logic generated for these attributes are emitted in the by-move block rather than the by-ref block that they would normally have been generated in.warnattribute already existing, so this name being unavailable for the derives to use.#[warn_]is used instead, which requires special-casing so that{span_,}warnis called instead of{span_,}warn_.rustc_passes::check_attrdiagnostics to using diagnostic derives and being translatable. I got tired after a while. I modified some diagnostic output for consistency while doing this, nothing too crazy.r? @compiler-errors