Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Fail gracefully when encountering an HRTB in APIT. #98462

Merged
merged 2 commits into from
Jun 26, 2022
Merged

[beta] Fail gracefully when encountering an HRTB in APIT. #98462

merged 2 commits into from
Jun 26, 2022

Conversation

cjgillot
Copy link
Contributor

Backport of #97683
The diagnostic is a bit worse, but still better than an ICE.

r? @ehuss

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 24, 2022
@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2022
@ehuss
Copy link
Contributor

ehuss commented Jun 24, 2022

LGTM.

@pietroalbini Not sure if you would prefer to pull this in with the beta promotion? Or just go ahead and merge it now?

@Mark-Simulacrum Mark-Simulacrum changed the title Fail gracefully when encountering an HRTB in APIT. [beta] Fail gracefully when encountering an HRTB in APIT. Jun 26, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Jun 26, 2022

📌 Commit a081507 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2022
@bors
Copy link
Contributor

bors commented Jun 26, 2022

⌛ Testing commit a081507 with merge b6ee5a350bc7576847e18b242440ac813c05c651...

@bors
Copy link
Contributor

bors commented Jun 26, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 26, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@pietroalbini
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2022
@bors
Copy link
Contributor

bors commented Jun 26, 2022

⌛ Testing commit a081507 with merge 747075d...

@bors
Copy link
Contributor

bors commented Jun 26, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 747075d to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 26, 2022
@bors bors merged commit 747075d into rust-lang:beta Jun 26, 2022
@rustbot rustbot added this to the 1.62.0 milestone Jun 26, 2022
@cjgillot cjgillot deleted the no-apit-hrtb-beta branch June 27, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehuss ehuss

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
8 participants
@cjgillot @rust-highfive @ehuss @Mark-Simulacrum @bors @rust-log-analyzer @pietroalbini @rustbot