Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 3 pull requests #97809

Merged
merged 14 commits into from
Jun 7, 2022
Merged

Rollup of 3 pull requests #97809

merged 14 commits into from
Jun 7, 2022

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

nzrq and others added 14 commits June 3, 2022 13:05
@nzrq
Add note to documentation of HashSet::intersection
2ea9e04
@nzrq
Update set.rs
fdd8b62
@nzrq @dtolnay
Update library/std/src/collections/hash/set.rs
fc4e8c7 
Co-authored-by: David Tolnay <[email protected]>
@GuillaumeGomez
Add "no-confusing-arrow" eslint check
116eec2
@GuillaumeGomez
Add "no-div-regex" eslint check
0e66868
@GuillaumeGomez
Add "no-floating-decimal" eslint check
b48bbd4
@GuillaumeGomez
Add "no-implicit-globals" eslint check
b827847
@GuillaumeGomez
Add "no-implied-eval" eslint check
d0909bd
@GuillaumeGomez
Add "no-label-var" eslint check
cd5e73b
@eltociear
Fix typo in redundant_pattern_match.rs
0664bd8 
alway -> always
@nzrq @dtolnay
Apply suggestions from code review
7d114c7 
Co-authored-by: David Tolnay <[email protected]>
@matthiaskrgr
Rollup merge of rust-lang#97700 - nzrq:patch-1, r=dtolnay
c4bfd10 
Add note to documentation of HashSet::intersection

The functionality of the `std::collections::HashSet::intersection(...)` method was slightly surprising to me so I wanted to take a sec to contribute to the documentation for this method.

I've added a `Note:` section if that is appropriate.
@matthiaskrgr
Rollup merge of rust-lang#97792 - GuillaumeGomez:eslint-checks, r=Dyl…
6be8b9c 
…an-DPC

More eslint checks

Here is the list of newly added eslint checks:

 * [no-confusing-arrow](https://eslint.org/docs/rules/no-confusing-arrow)
 * [no-div-regex](https://eslint.org/docs/rules/no-div-regex)
 * [no-floating-decimal](https://eslint.org/docs/rules/no-floating-decimal)
 * [no-implicit-globals](https://eslint.org/docs/rules/no-implicit-globals)
 * [no-implied-eval](https://eslint.org/docs/rules/no-implied-eval)
 * [no-label-var](https://eslint.org/docs/rules/no-label-var)

Since you already reviewed the previous ones:

r? `@Dylan-DPC`
@matthiaskrgr
Rollup merge of rust-lang#97794 - eltociear:patch-13, r=matthiaskrgr
fece76d 
Fix typo in redundant_pattern_match.rs

alway -> always
@rustbot rustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jun 6, 2022
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=3

@bors
Copy link
Contributor

bors commented Jun 6, 2022

📌 Commit fece76d has been approved by matthiaskrgr

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 6, 2022
@bors
Copy link
Contributor

bors commented Jun 6, 2022

⌛ Testing commit fece76d with merge 54aa8a7...

@bors
Copy link
Contributor

bors commented Jun 7, 2022

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 54aa8a7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 7, 2022
@bors bors merged commit 54aa8a7 into rust-lang:master Jun 7, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 7, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (54aa8a7): comparison url.

Instruction count

  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 0.3% 0.5% 7
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 0.3% 0.5% 7

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 2.3% 2.3% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@rustbot rustbot added the perf-regression Performance regression. label Jun 7, 2022
@rylev
Copy link
Member

rylev commented Jun 7, 2022

This looks to be caused by some variability in the Diesel benchmark. The regressions seen here are reveresed in the next PR (an update to Miri).

#97801 (Comparison Link)

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Jun 7, 2022
@matthiaskrgr matthiaskrgr deleted the rollup-ajyvjd3 branch July 30, 2022 10:32
@lqd lqd mentioned this pull request Aug 18, 2023
Closed
This was referenced Nov 17, 2023
Closed
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 29, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
8 participants
@matthiaskrgr @bors @rust-timer @rylev @rustbot @nzrq @GuillaumeGomez @eltociear