Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bootstrap] Move sanitize_sh from dist to install #97466

Merged
merged 1 commit into from
May 28, 2022

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented May 27, 2022

This is the only place it's used, so there's no need for it to be public in another module.
In general, dist shouldn't ever touch shell scripts.

This is the only place it's used, so there's no need for it to be public in another module.
In general, `dist` shouldn't ever touch shell scripts.
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 27, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 28, 2022

📌 Commit 81e2c11 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 28, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#94640 (Partially stabilize `(const_)slice_ptr_len` feature by stabilizing `NonNull::len`)
 - rust-lang#97034 (Implement `Hash` for `core::alloc::Layout`)
 - rust-lang#97327 (macros: introduce `fluent_messages` macro )
 - rust-lang#97448 (docs: Don't imply that OsStr on Unix is always UTF-8)
 - rust-lang#97466 ([bootstrap] Move `sanitize_sh` from `dist` to `install`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5badc29 into rust-lang:master May 28, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 28, 2022
@jyn514 jyn514 deleted the consolidate-install branch February 25, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants