Drop tracking: handle invalid assignments better #97031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this test case was crashing with an index out of bounds error deep in the call to `needs_drop`. We avoid this by detecting clearly invalid assignees in the `mutate` callback and ignoring these.
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 5c98737 has been approved by |
bors
added
S-waiting-on-bors
|
@bors r- wait one nit |
bors
added
S-waiting-on-author
compiler/rustc_typeck/src/check/generator_interior/drop_ranges/record_consumed_borrow.rs
Outdated
Show resolved
Hide resolved
|
@bors delegate+ sorry for the r+/r- whiplash, fix the nit or don't -- up to you :) |
|
✌️ @eholk can now approve this pull request |
|
Thanks for the quick review! @bors r=compiler-errors |
|
📌 Commit 6665a43 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 14, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#95365 (Use default alloc_error_handler for hermit) - rust-lang#96986 ([save-analysis] Reference the variant not enum at struct-literal cons…) - rust-lang#96998 (rustdoc: remove weird, unused variable from source-files.js) - rust-lang#97005 (Two small improvements of rustc_expand) - rust-lang#97018 (Ensure that test fail if a JS error occurs) - rust-lang#97031 (Drop tracking: handle invalid assignments better) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this test case was crashing with an index out of bounds error deep in the call to
needs_drop. We avoid this by detecting clearly invalid assignees in themutatecallback and ignoring these.