Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ignore from E0705 test #96580

Merged
merged 1 commit into from
May 3, 2022
Merged

Remove ignore from E0705 test #96580

merged 1 commit into from
May 3, 2022

Conversation

CAD97
Copy link
Contributor

@CAD97 CAD97 commented Apr 30, 2022

Spotted this, and I think this can be made to test now.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 30, 2022
@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 30, 2022
@CAD97 CAD97 changed the title Remove ` ignore```` from E0705 test Remove ignore from E0705 test Apr 30, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@CAD97 CAD97 force-pushed the E0705-no-ignore branch from f6cb6f3 to 09f758f Compare April 30, 2022 15:48
@michaelwoerister
Copy link
Member

Thanks @CAD97! Let's give it a try.
@bors r+

@bors
Copy link
Contributor

bors commented May 2, 2022

📌 Commit 09f758f has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2022
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 2, 2022
@GuillaumeGomez
Rollup merge of rust-lang#96580 - CAD97:E0705-no-ignore, r=michaelwoe…
3ff71e9 
…rister

Remove `ignore` from E0705 test

Spotted this, and I think this can be made to test now.
@GuillaumeGomez GuillaumeGomez mentioned this pull request May 2, 2022
Closed
@bors
Copy link
Contributor

bors commented May 3, 2022

⌛ Testing commit 09f758f with merge c110cfa...

@bors
Copy link
Contributor

bors commented May 3, 2022

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing c110cfa to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 3, 2022
@bors bors merged commit c110cfa into rust-lang:master May 3, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 3, 2022
@CAD97 CAD97 deleted the E0705-no-ignore branch May 3, 2022 03:22
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c110cfa): comparison url.

Summary:

  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: no relevant changes found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 0 0 1 0 1
mean2 N/A N/A -0.2% N/A -0.2%
max N/A N/A -0.2% N/A -0.2%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes ↩

  2. the arithmetic mean of the percent change ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
7 participants
@CAD97 @rust-highfive @rust-log-analyzer @michaelwoerister @bors @rust-timer @rustbot