Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debuginfo: Fix bug in type name generation for dyn types with associated types but no other generic arguments. #94810

Merged
merged 1 commit into from
Mar 15, 2022
Merged

debuginfo: Fix bug in type name generation for dyn types with associated types but no other generic arguments. #94810

merged 1 commit into from
Mar 15, 2022

Conversation

michaelwoerister
Copy link
Member

For types like &dyn Future<Output=bool> the compiler currently emits invalid types names in debuginfo. This PR fixes this.

Before:

// DWARF
&dyn core::future::future::Future, Output=bool> 

// CodeView
ref$<dyn$<core::future::future::Future,assoc$<Output,bool> > > >

After:

// DWARF
&dyn core::future::future::Future<Output=bool> 

// CodeView
ref$<dyn$<core::future::future::Future<assoc$<Output,bool> > > >

These syntactically incorrect type names can cause downstream tools (e.g. debugger extensions) crash when trying to parse them.

r? @wesleywiser

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 10, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 10, 2022
@wesleywiser
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 15, 2022

📌 Commit 5cd8a2a has been approved by wesleywiser

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 15, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 15, 2022
@bors
Auto merge of rust-lang#94966 - matthiaskrgr:rollup-iqzswh3, r=matthi…
83460d5 
…askrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#94810 (debuginfo: Fix bug in type name generation for dyn types with associated types but no other generic arguments.)
 - rust-lang#94947 (fix typos)
 - rust-lang#94956 (Fix small typo in FIXME)
 - rust-lang#94958 (Support other types of pluralization in pluralize macro)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Mar 15, 2022

⌛ Testing commit 5cd8a2a with merge 83460d5...

@bors bors merged commit e755f2c into rust-lang:master Mar 15, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
5 participants
@michaelwoerister @wesleywiser @bors @rust-highfive @rustbot