add methods to TCP and UDP sockets to modify hop limit #94678

kckeiks · 2022-03-06T18:06:15Z

adds methods to set value of IPV6_UNICAST_HOPS and IPV6_MULTICAST_HOPS on ipv6 sockets
I added some noop methods for different systems to keep things consistent. Maybe someone could please clarify if these noop funcs are needed? and, if so, why? Just for my own learning.

This is my first addition of a new feature so let me know if I missed something in the process. I read the rustc dev guide about implementing new features but since the change here is simple, it suggested that a PR would be enough.

Fixes #47727

rust-highfive · 2022-03-06T18:06:18Z

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

kennytm · 2022-03-07T06:42:05Z

library/std/src/net/tcp.rs

+    /// stream.set_multicast_hlim_v6(88).expect("set_hop_limit_v6 call failed");
+    /// ```
+    #[unstable(feature = "ipv6_hop_limit", issue = "47727")]
+    pub fn set_multicast_hlim_v6(&self, limit: u32) -> io::Result<()> {


why thi is "hlim" here but "hop_limit" for unicast

I was trying to keep the length of the method name from being too long. Should I change it to "hop_limit"?

Yes. Rust doesn't generally abbreviate.

I updated the method names.

the8472 · 2022-05-21T10:24:39Z

IPV6_UNICAST_HOPS and IPV6_MULTICAST_HOPS are standardized in IETF RFC 3493 so this should be a good cross-platform addition.

Since it adds new API surface: r? rust-lang/libs-api

bors · 2022-06-07T08:05:05Z

☔ The latest upstream changes (presumably #95565) made this pull request unmergeable. Please resolve the merge conflicts.

joshtriplett · 2022-10-03T13:21:11Z

This seems fine, assuming it passes CI. Let's see if the requisite constants are defined on all platforms...

@bors r+

bors · 2022-10-03T13:21:13Z

📌 Commit b3e9e94 has been approved by joshtriplett

It is now in the queue for this repository.

…joshtriplett add methods to TCP and UDP sockets to modify hop limit * adds methods to set value of IPV6_UNICAST_HOPS and IPV6_MULTICAST_HOPS on ipv6 sockets * I added some noop methods for different systems to keep things consistent. Maybe someone could please clarify if these noop funcs are needed? and, if so, why? Just for my own learning. This is my first addition of a new feature so let me know if I missed something in the process. I read the rustc dev guide about implementing new features but since the change here is simple, it suggested that a PR would be enough. Fixes rust-lang#47727

bors · 2022-10-04T00:27:59Z

⌛ Testing commit b3e9e94 with merge f5cfbb23b1def2ab0d4dfe01c13340628b453cd6...

bors · 2022-10-04T00:56:08Z

💔 Test failed - checks-actions

rust-log-analyzer · 2022-10-04T03:29:44Z

The job dist-various-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)


error: unused variable: `limit`
   --> library/std/src/sys/sgx/net.rs:456:36
    |
456 |     pub fn set_hop_limit_v6(&self, limit: u32) -> io::Result<()> {
    |                                    ^^^^^ help: if this is intentional, prefix it with an underscore: `_limit`
    |
    = note: `-D unused-variables` implied by `-D warnings`
error: unused variable: `limit`
   --> library/std/src/sys/sgx/net.rs:464:46
    |
    |
464 |     pub fn set_multicast_hop_limit_v6(&self, limit: u32) -> io::Result<()> {
    |                                              ^^^^^ help: if this is intentional, prefix it with an underscore: `_limit`
[RUSTC-TIMING] std test:false 3.547
warning: `std` (lib) generated 1 warning
error: could not compile `std` due to 2 previous errors; 1 warning emitted
Build completed unsuccessfully in 0:22:44

pietroalbini · 2022-10-05T09:13:37Z

@bors r-

Queue got messed up after a synchronize.

bors · 2022-10-15T05:02:47Z

☔ The latest upstream changes (presumably #98033) made this pull request unmergeable. Please resolve the merge conflicts.

mominul · 2022-10-15T07:59:09Z

library/std/src/net/tcp.rs

+    /// stream.set_hop_limit_v6(88).expect("set_hop_limit_v6 call failed");
+    /// ```
+    #[unstable(feature = "ipv6_hop_limit", issue = "47727")]
+    pub fn set_hop_limit_v6(&self, limit: u32) -> io::Result<()> {


Hop Limit is an 8bit header field. So using u8 instead of u32 would reflect that better and avoid API misusage like #73158.

Dylan-DPC · 2022-11-12T09:14:04Z

@kckeiks any updates on this?

kckeiks · 2022-11-12T17:43:25Z

@kckeiks any updates on this?

Sorry, I've been super busy, I will push an update sometime this week though.

kckeiks · 2023-01-20T04:06:57Z

Just following up. My apologies, work has been keeping me exceedingly busy so I'm not sure when I'll have some bandwidth to resolve this. :/

Dylan-DPC · 2023-01-20T10:07:01Z

Just following up. My apologies, work has been keeping me exceedingly busy so I'm not sure when I'll have some bandwidth to resolve this. :/

That's fine, can understand. I am going to close this as it is inactive. If you find the time feel free to reöpen it or preferably create a new PR and we can take it from there. Thanks

kckeiks added 4 commits March 6, 2022 12:58

add setters and getters for ipv6 socket hop limit

ac288b4

add setters for hop limit to tcp listener and stream and update tests

44c2226

add noop methods for other sys

c60ab7b

add unicast and multicast hop limit option for windows

090c1c9

rust-highfive assigned kennytm Mar 6, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 6, 2022

This comment has been minimized.

Sign in to view

cleanup - remove whitespace

6d0d29e

This comment has been minimized.

Sign in to view

fix broken intra doc links

36096cf

kckeiks changed the title ~~add methods to TCP and UDP sockets modify hop limit~~ add methods to TCP and UDP sockets to modify hop limit Mar 6, 2022

kennytm reviewed Mar 7, 2022

View reviewed changes

rename multicast methods

b3e9e94

kckeiks requested review from kennytm and joshtriplett March 15, 2022 21:08

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2022

apiraino added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 19, 2022

the8472 added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 21, 2022

rust-highfive assigned joshtriplett and unassigned kennytm May 21, 2022

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2022

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2022

matthiaskrgr mentioned this pull request Oct 3, 2022

Rollup of 6 pull requests #102636

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 4, 2022

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2022

mominul reviewed Oct 15, 2022

View reviewed changes

Dylan-DPC closed this Jan 20, 2023

Dylan-DPC added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add methods to TCP and UDP sockets to modify hop limit #94678

add methods to TCP and UDP sockets to modify hop limit #94678

kckeiks commented Mar 6, 2022 •

edited

Loading

rust-highfive commented Mar 6, 2022

This comment has been minimized.

This comment has been minimized.

kennytm Mar 7, 2022

kckeiks Mar 7, 2022

joshtriplett Mar 8, 2022

kckeiks Mar 8, 2022

the8472 commented May 21, 2022

bors commented Jun 7, 2022

joshtriplett commented Oct 3, 2022

bors commented Oct 3, 2022

bors commented Oct 4, 2022

bors commented Oct 4, 2022

rust-log-analyzer commented Oct 4, 2022

pietroalbini commented Oct 5, 2022

bors commented Oct 15, 2022

mominul Oct 15, 2022

Dylan-DPC commented Nov 12, 2022

kckeiks commented Nov 12, 2022

kckeiks commented Jan 20, 2023

Dylan-DPC commented Jan 20, 2023

add methods to TCP and UDP sockets to modify hop limit #94678

add methods to TCP and UDP sockets to modify hop limit #94678

Conversation

kckeiks commented Mar 6, 2022 • edited Loading

rust-highfive commented Mar 6, 2022

This comment has been minimized.

This comment has been minimized.

kennytm Mar 7, 2022

Choose a reason for hiding this comment

kckeiks Mar 7, 2022

Choose a reason for hiding this comment

joshtriplett Mar 8, 2022

Choose a reason for hiding this comment

kckeiks Mar 8, 2022

Choose a reason for hiding this comment

the8472 commented May 21, 2022

bors commented Jun 7, 2022

joshtriplett commented Oct 3, 2022

bors commented Oct 3, 2022

bors commented Oct 4, 2022

bors commented Oct 4, 2022

rust-log-analyzer commented Oct 4, 2022

pietroalbini commented Oct 5, 2022

bors commented Oct 15, 2022

mominul Oct 15, 2022

Choose a reason for hiding this comment

Dylan-DPC commented Nov 12, 2022

kckeiks commented Nov 12, 2022

kckeiks commented Jan 20, 2023

Dylan-DPC commented Jan 20, 2023

kckeiks commented Mar 6, 2022 •

edited

Loading