Linkify sidebar headings for sibling items #93673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in HTML/CSS/JS. |
rustbot
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
| @@ -39,4 +39,4 @@ assert-position: ("#method\.must_use", {"y": 45}) | |||
| // Check that the bottom-most item on the sidebar menu can be scrolled fully into view. | |||
| click: ".sidebar-menu-toggle" | |||
| scroll-to: ".block.keyword li:nth-child(1)" | |||
| assert-position: (".block.keyword li:nth-child(1)", {"y": 542.96875}) | |||
| assert-position: (".block.keyword li:nth-child(1)", {"y": 542.234375}) | |||
There was a problem hiding this comment.
With latest version, you can just check with 542 (which is much better for reading).
GuillaumeGomez
approved these changes
Feb 5, 2022
|
Did you try with the latest browser-ui-test version for background-color bug? Also I wonder if it's linked to |
Also adjust CSS so this doesn't produce excess padding/margin.
jsha
force-pushed
the
linkify-sidebar-headings
branch
from
97bd985
to
e27ebb5
Compare
|
I tried the background-color test again, and it worked, even on the current version of browser-ui-test. I suspect I may have been typoing the anchor name before. |
GuillaumeGomez
approved these changes
Feb 7, 2022
|
Perfect then! Thanks! @bors: r+ rollup |
|
@GuillaumeGomez: 🔑 Insufficient privileges: Not in reviewers |
|
Weird again... @bors: r+ |
|
📌 Commit e27ebb5 has been approved by |
bors
added
S-waiting-on-bors
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Feb 7, 2022
…illaumeGomez
Linkify sidebar headings for sibling items
Also adjust CSS so this doesn't produce excess padding/margin.
Note: I tried and failed to write a test with browser-UI-test. First I tried to `assert-property: (".block.mod h3 a", {"href": "index.html#macros"})`. But the `href` that gets read out is the fully-quallified URL, starting with `file:///`. That URL will differ depending on what path the test is run from, so that doesn't work.
Next I tried clicking on the appropriate sidebar link, and verifying that the appropriate heading on the next page is highlighted with the right background color. However, that also didn't work: according to browser-UI-test, the targeted heading was plain white. However, running with no-headless, I could see that it actually was yellow. I suspect this is a bug in the older version of Chromium used with browser-UI-test's bundled puppeteer, since it doesn't reproduce on latest Chrome.
Fixes rust-lang#92957
Demo: https://rustdoc.crud.net/jsha/linkify-sidebar-headings/std/string/trait.ToString.html
r? `@GuillaumeGomez`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 7, 2022
Rollup of 13 pull requests Successful merges: - rust-lang#88313 (Make the pre-commit script pre-push instead) - rust-lang#91530 (Suggest 1-tuple parentheses on exprs without existing parens) - rust-lang#92724 (Cleanup c_str.rs) - rust-lang#93208 (Impl {Add,Sub,Mul,Div,Rem,BitXor,BitOr,BitAnd}Assign<$t> for Wrapping<$t> for rust 1.60.0) - rust-lang#93394 (Don't allow {} to refer to implicit captures in format_args.) - rust-lang#93416 (remove `allow_fail` test flag) - rust-lang#93487 (Fix linking stage1 toolchain in `./x.py setup`) - rust-lang#93673 (Linkify sidebar headings for sibling items) - rust-lang#93680 (Drop json::from_reader) - rust-lang#93682 (Update tracking issue for `const_fn_trait_bound`) - rust-lang#93722 (Use shallow clones for submodules managed by rustbuild, not just bootstrap.py) - rust-lang#93723 (Rerun bootstrap's build script when RUSTC changes) - rust-lang#93737 (bootstrap: prefer using '--config' over 'RUST_BOOTSTRAP_CONFIG') Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adjust CSS so this doesn't produce excess padding/margin.
Note: I tried and failed to write a test with browser-UI-test. First I tried to
assert-property: (".block.mod h3 a", {"href": "index.html#macros"}). But thehrefthat gets read out is the fully-quallified URL, starting withfile:///. That URL will differ depending on what path the test is run from, so that doesn't work.Next I tried clicking on the appropriate sidebar link, and verifying that the appropriate heading on the next page is highlighted with the right background color. However, that also didn't work: according to browser-UI-test, the targeted heading was plain white. However, running with no-headless, I could see that it actually was yellow. I suspect this is a bug in the older version of Chromium used with browser-UI-test's bundled puppeteer, since it doesn't reproduce on latest Chrome.
Fixes #92957
Demo: https://rustdoc.crud.net/jsha/linkify-sidebar-headings/std/string/trait.ToString.html
r? @GuillaumeGomez