Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing platform-specific information on current_dir and set_current_dir #93635

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Add missing platform-specific information on current_dir and set_current_dir #93635

merged 1 commit into from
Feb 12, 2022

Conversation

GuillaumeGomez
Copy link
Member

Fixes #93598.

@rust-highfive
Copy link
Collaborator

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2022
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 3, 2022
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the missing-platform-spec-info branch from 5d1db2c to deec7f7 Compare February 3, 2022 22:33
@GuillaumeGomez GuillaumeGomez added T-libs Relevant to the library team, which will review and decide on the PR/issue. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Feb 11, 2022
@GuillaumeGomez
Copy link
Member Author

r? @Amanieu

@rust-highfive rust-highfive assigned Amanieu and unassigned yaahc Feb 11, 2022
Amanieu
Amanieu reviewed Feb 11, 2022
View reviewed changes
Copy link
Member

@Amanieu Amanieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from minor style nits.

library/std/src/env.rs Outdated Show resolved Hide resolved
library/std/src/env.rs Outdated Show resolved Hide resolved
@GuillaumeGomez GuillaumeGomez force-pushed the missing-platform-spec-info branch from deec7f7 to 22a24c9 Compare February 11, 2022 15:33
@GuillaumeGomez
Copy link
Member Author

@Amanieu Good catch, thanks!

@bors: r=Amanieu rollup

@bors
Copy link
Contributor

bors commented Feb 11, 2022

📌 Commit 22a24c9 has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 11, 2022
@matthiaskrgr
Rollup merge of rust-lang#93635 - GuillaumeGomez:missing-platform-spe…
7020697 
…c-info, r=Amanieu

Add missing platform-specific information on current_dir and set_current_dir

Fixes rust-lang#93598.
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 11, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 11, 2022
@matthiaskrgr
Rollup merge of rust-lang#93635 - GuillaumeGomez:missing-platform-spe…
a023e7b 
…c-info, r=Amanieu

Add missing platform-specific information on current_dir and set_current_dir

Fixes rust-lang#93598.
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 11, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 11, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 11, 2022
@bors
Auto merge of rust-lang#93921 - matthiaskrgr:rollup-wn3jlxj, r=matthi…
f198510 
…askrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#90955 (Rename `FilenameTooLong` to `InvalidFilename` and also use it for Windows' `ERROR_INVALID_NAME`)
 - rust-lang#91607 (Make `span_extend_to_prev_str()` more robust)
 - rust-lang#92895 (Remove some unused functionality)
 - rust-lang#93635 (Add missing platform-specific information on current_dir and set_current_dir)
 - rust-lang#93660 (rustdoc-json: Add some tests for typealias item)
 - rust-lang#93782 (Split `pauth` target feature)
 - rust-lang#93868 (Fix incorrect register conflict detection in asm!)
 - rust-lang#93888 (Implement `AsFd` for `&T` and `&mut T`.)
 - rust-lang#93909 (Fix typo: explicitely -> explicitly)
 - rust-lang#93910 (fix mention of moved function in `rustc_hir` docs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 15d71cf into rust-lang:master Feb 12, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 12, 2022
@GuillaumeGomez GuillaumeGomez deleted the missing-platform-spec-info branch February 12, 2022 12:00
@AustinScola
Copy link

Thanks for documenting this! I just ran into this, where I didn't expect std::env::current_dir to return the canonicalized path (and I actually wanted the non-canonicalized path). This added documentation would probably have helped me figure it out faster.

@GuillaumeGomez
Copy link
Member Author

Glad it helped!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amanieu Amanieu Amanieu left review comments

Assignees

@Amanieu Amanieu

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.

Document canonicalization in std::env::current_dir
8 participants
@GuillaumeGomez @rust-highfive @rust-log-analyzer @bors @AustinScola @Amanieu @yaahc @rustbot