Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: Implement try_reserve and try_reserve_exact on PathBuf #92513

Merged
merged 1 commit into from
Jan 24, 2022
Merged

std: Implement try_reserve and try_reserve_exact on PathBuf #92513

merged 1 commit into from
Jan 24, 2022

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Jan 3, 2022

Part of #91789

Signed-off-by: Xuanwo [email protected]

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 3, 2022
@Xuanwo Xuanwo mentioned this pull request Jan 3, 2022
Closed
5 tasks
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jan 11, 2022

@kennytm, Hi, do you have time to review this PR? Thanks in advance.

@TennyZhuang
Copy link
Contributor

r? @dtolnay

Can you take a look with this PR? which is similar to #92338

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jan 24, 2022

r? @yaahc Can you take a look with this PR? Thanks in advance.

@rust-highfive rust-highfive assigned yaahc and unassigned kennytm Jan 24, 2022
dtolnay
dtolnay approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Not sure why this didn't get assigned to me after the comment above.

@dtolnay
Copy link
Member

dtolnay commented Jan 24, 2022

@bors r+

@dtolnay dtolnay assigned dtolnay and unassigned yaahc Jan 24, 2022
@bors
Copy link
Contributor

bors commented Jan 24, 2022

📌 Commit edae82e has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 24, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2022
@bors
Auto merge of rust-lang#93260 - matthiaskrgr:rollup-c5b9c76, r=matthi…
51126be 
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#92513 (std: Implement try_reserve and try_reserve_exact on PathBuf)
 - rust-lang#93152 (Fix STD compilation for the ESP-IDF target (regression from CVE-2022-21658))
 - rust-lang#93186 (Fix link to CVE-2022-21658)
 - rust-lang#93188 (rustdoc: fix bump down typing search on Safari)
 - rust-lang#93212 (Remove unneeded cursor pointer rule on mobile sidebar)
 - rust-lang#93231 (adjust sidebar link brightness)
 - rust-lang#93241 (Fix brief appearance of rust logo in the sidebar)
 - rust-lang#93253 (Update theme on pageshow event)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b92a1e9 into rust-lang:master Jan 24, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 24, 2022
@Xuanwo Xuanwo deleted the path-buf branch January 24, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Xuanwo @rust-highfive @TennyZhuang @dtolnay @bors @kennytm @yaahc @rustbot