-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new opaque type predicate #92046
Conversation
It's not emitted yet and most logic for it doesn't exist. This commit exists solely to make future changes smaller
The job Click to see the possible cause of the failure (guessed by this bot)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any documentation as to why this is needed? If there is, can you made add that here somewhere? If not, can you explain a bit?
/// The arguments may be in any order, but one of them must be an opaque type. | ||
/// The order and the boolean is used for resolving which opaque type defines | ||
/// the other if both are opaque types and for diagnostics. | ||
OpaqueType(Ty<'tcx>, Ty<'tcx>, bool), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just make the left be the opaque type being defined, and get rid of the bool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I tried that but got messed up diagnostics, but I'll try again
Closing in favour of merging #92007 in one go by allocating a pair-review session with niko and lcnr |
It's not emitted yet and most logic for it doesn't exist.
This commit exists solely to make future changes smaller
r? @jackh726
this is one of the changes I mean in #92007 (comment)
Merging this will make further work easier to review and less bitrotty, but this PR has no logic changes to the actual execution of the compiler.