Make TyS::is_suggestable check for non-suggestable types structually
#91898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
cc: @estebank, who might care about changes in diagnostic type annotations. |
lcnr
reviewed
Dec 14, 2021
| fn generic_arg_is_suggestible(arg: GenericArg<'_>) -> bool { | ||
| match arg.unpack() { | ||
| GenericArgKind::Type(ty) => ty.is_suggestable(), | ||
| _ => true, |
compiler-errors
force-pushed
the
dont_suggest_closure_return_type
branch
from
c457ee2
to
2215186
Compare
compiler-errors
force-pushed
the
dont_suggest_closure_return_type
branch
from
2215186
to
f29fb47
Compare
|
@bors r+ rollup |
|
📌 Commit f29fb47 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 15, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#91880 (fix clippy::single_char_pattern perf findings) - rust-lang#91885 (Remove `in_band_lifetimes` from `rustc_codegen_ssa`) - rust-lang#91898 (Make `TyS::is_suggestable` check for non-suggestable types structually) - rust-lang#91915 (Add another regression test for unnormalized fn args with Self) - rust-lang#91916 (Fix a bunch of typos) - rust-lang#91918 (Constify `bool::then{,_some}`) - rust-lang#91920 (Use `tcx.def_path_hash` in `ExistentialPredicate.stable_cmp`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
I was sad to see some of the suggestions go away, so I created #91981 that builds on top of this one. |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 27, 2022
Recover suggestions and useful information lost in previous PR Follow up to rust-lang#91898.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if I went overboard checking substs in dyn types, etc. Let me know if I should simplify this function.
Fixes #91832