Refactor EmitterWriter::emit_suggestion_default #91250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I just noticed a regression in src/test/ui/suggestions/suggest-change-mut.stderr due to the logic change. |
rukai
force-pushed
the
remove_trailing_whitespace
branch
from
8325a61 to
a5c7215
Compare
rukai
changed the title
This comment has been minimized.
This comment has been minimized.
rukai
force-pushed
the
remove_trailing_whitespace
branch
from
a5c7215 to
df3e7a2
Compare
wesleywiser
approved these changes
Nov 29, 2021
|
📌 Commit df3e7a2 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 30, 2021
…=wesleywiser Refactor EmitterWriter::emit_suggestion_default Makes progress towards rust-lang#89979 Split into 2 commits: * the first commit is purely a refactor and I verified that `./x.py test src/test/ui --stage 1` and `./x.py test src/test/rustdoc-ui --stage 1` continue to pass on this commit. * ~~the second commit removes the empty trailing line from diff style suggestions.~~ - I discovered an issue with this so its just the refactor now. r? diagnostics
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 30, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#91243 (Don't treat unnormalized function arguments as well-formed) - rust-lang#91250 (Refactor EmitterWriter::emit_suggestion_default ) - rust-lang#91317 (tests: Ignore `test/debuginfo/rc_arc.rs` on windows-gnu) - rust-lang#91323 (CTFE: support assert_zero_valid and assert_uninit_valid) - rust-lang#91358 (Fix small typo) - rust-lang#91360 (:arrow_up: rust-analyzer) - rust-lang#91368 (Don't re-export `MirPass`) - rust-lang#91383 (Add `drop_while` as doc alias to `Iterator::skip_while`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes progress towards #89979
Split into 2 commits:
./x.py test src/test/ui --stage 1and./x.py test src/test/rustdoc-ui --stage 1continue to pass on this commit.the second commit removes the empty trailing line from diff style suggestions.- I discovered an issue with this so its just the refactor now.r? diagnostics