Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Remove Crate.externs and compute on-demand instead #91066

Merged
merged 4 commits into from
Nov 20, 2021
Merged

rustdoc: Remove Crate.externs and compute on-demand instead #91066

merged 4 commits into from
Nov 20, 2021

Conversation

camelid
Copy link
Member

@camelid camelid commented Nov 20, 2021

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 20, 2021
@camelid camelid added C-cleanup Category: PRs that clean code up or issues documenting cleanup. I-compilemem Issue: Problems and improvements with respect to memory usage during compilation. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@camelid
rustdoc: Move doc-reachability visiting back to cleaning
bbc3825 
It populates `cx.cache.access_levels`, which seems to be needed during
cleaning since a bunch of tests are failing.
@camelid
Copy link
Member Author

camelid commented Nov 20, 2021

@bors rollup=never

@camelid camelid added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 20, 2021
@camelid
Copy link
Member Author

camelid commented Nov 20, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 20, 2021
@bors
Copy link
Contributor

bors commented Nov 20, 2021

⌛ Trying commit bbc3825 with merge fa4bd5e2d3e9a77104d23aef85b2d36578b94eb3...

jyn514
jyn514 reviewed Nov 20, 2021
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol you'd already fixed my one comment by the time I finished the review, nice

@jyn514
Copy link
Member

jyn514 commented Nov 20, 2021

Anyway, this looks good whether or not it's a perf improvement, r=me

@jyn514 jyn514 assigned jyn514 and unassigned GuillaumeGomez Nov 20, 2021
@jyn514 jyn514 removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 20, 2021
@camelid camelid added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 20, 2021
@bors
Copy link
Contributor

bors commented Nov 20, 2021

☀️ Try build successful - checks-actions
Build commit: fa4bd5e2d3e9a77104d23aef85b2d36578b94eb3 (fa4bd5e2d3e9a77104d23aef85b2d36578b94eb3)

@rust-timer
Copy link
Collaborator

Queued fa4bd5e2d3e9a77104d23aef85b2d36578b94eb3 with parent a77da2d, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fa4bd5e2d3e9a77104d23aef85b2d36578b94eb3): comparison url.

Summary: This change led to large relevant regressions 😿 in compiler performance.

  • Large regression in instruction counts (up to 3.9% on incr-unchanged builds of deep-vector)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Nov 20, 2021
@GuillaumeGomez
Copy link
Member

It seems like it doesn't impact performance or memory usage. I'm a bit surprised but doesn't matter. Thanks for the simplification!

@bors: r=jyn514,GuillaumeGomez

@bors
Copy link
Contributor

bors commented Nov 20, 2021

📌 Commit bbc3825 has been approved by jyn514,GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 20, 2021
@bors
Copy link
Contributor

bors commented Nov 20, 2021

⌛ Testing commit bbc3825 with merge 93542a8...

@bors
Copy link
Contributor

bors commented Nov 20, 2021

☀️ Test successful - checks-actions
Approved by: jyn514,GuillaumeGomez
Pushing 93542a8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 20, 2021
@bors bors merged commit 93542a8 into rust-lang:master Nov 20, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 20, 2021
@camelid camelid deleted the externs branch November 20, 2021 17:31
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (93542a8): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@rustbot rustbot removed the perf-regression Performance regression. label Nov 20, 2021
@mathstuf mathstuf mentioned this pull request Nov 22, 2021
Closed
@mathstuf
Copy link
Contributor

It looks like this is probably the cause of a regression. See #91134.

@camelid
Copy link
Member Author

camelid commented Nov 22, 2021

Update from that issue: the regression is likely from somewhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@jyn514 jyn514

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. I-compilemem Issue: Problems and improvements with respect to memory usage during compilation. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
9 participants
@camelid @rust-log-analyzer @rust-timer @bors @jyn514 @GuillaumeGomez @mathstuf @rust-highfive @rustbot