-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #90437
Rollup of 4 pull requests #90437
Commits on Oct 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 17f4181 - Browse repository at this point
Copy the full SHA 17f4181View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf9e6e5 - Browse repository at this point
Copy the full SHA bf9e6e5View commit details
Commits on Oct 8, 2021
-
Let stack_overflow::imp::cleanup call drop_handler directly
instead of through the Drop impl for Handler
Configuration menu - View commit details
-
Copy full SHA for d2c8377 - Browse repository at this point
Copy the full SHA d2c8377View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cc4cce - Browse repository at this point
Copy the full SHA 0cc4cceView commit details
Commits on Oct 30, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6745e8d - Browse repository at this point
Copy the full SHA 6745e8dView commit details
Commits on Oct 31, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a81d4b1 - Browse repository at this point
Copy the full SHA a81d4b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e129d49 - Browse repository at this point
Copy the full SHA e129d49View commit details -
Rollup merge of rust-lang#89068 - bjorn3:restructure_rt2, r=joshtriplett
Restructure std::rt (part 2) A couple more cleanups on top of rust-lang#89011 Blocked on rust-lang#89011
Configuration menu - View commit details
-
Copy full SHA for 6c5aa76 - Browse repository at this point
Copy the full SHA 6c5aa76View commit details -
Rollup merge of rust-lang#89786 - jkugelman:must-use-len-and-is_empty…
…, r=joshtriplett Add #[must_use] to len and is_empty Parent issue: rust-lang#89692 r? `@joshtriplett`
Configuration menu - View commit details
-
Copy full SHA for 88e5ae2 - Browse repository at this point
Copy the full SHA 88e5ae2View commit details -
Rollup merge of rust-lang#90430 - jkugelman:must-use-std-a-through-n,…
… r=joshtriplett Add #[must_use] to remaining std functions (A-N) I've run out of compelling reasons to group functions together across crates so I'm just going to go module-by-module. This is half of the remaining items from the `std` crate, from A-N. I added these functions myself. Clippy predictably ignored the `mut` ones, but I don't know why the rest weren't flagged. Check them closely, please? Maybe I overlooked good reasons. ```rust std::backtrace::Backtrace const fn disabled() -> Backtrace; std::backtrace::Backtrace<'a> fn frames(&'a self) -> &'a [BacktraceFrame]; std::collections::hash_map::RawOccupiedEntryMut<'a, K, V> fn key_mut(&mut self) -> &mut K; std::collections::hash_map::RawOccupiedEntryMut<'a, K, V> fn get_mut(&mut self) -> &mut V; std::collections::hash_map::RawOccupiedEntryMut<'a, K, V> fn get_key_value(&mut self) -> (&K, &V); std::collections::hash_map::RawOccupiedEntryMut<'a, K, V> fn get_key_value_mut(&mut self) -> (&mut K, &mut V); std::env fn var_os<K: AsRef<OsStr>>(key: K) -> Option<OsString>; std::env fn split_paths<T: AsRef<OsStr> + ?Sized>(unparsed: &T) -> SplitPaths<'_>; std::io::Error fn get_mut(&mut self) -> Option<&mut (dyn error::Error + Send + Sync + 'static)>; ``` Parent issue: rust-lang#89692 r? `@joshtriplett`
Configuration menu - View commit details
-
Copy full SHA for 26f505c - Browse repository at this point
Copy the full SHA 26f505cView commit details -
Rollup merge of rust-lang#90431 - jkugelman:must-use-std-o-through-z,…
… r=joshtriplett Add #[must_use] to remaining std functions (O-Z) I've run out of compelling reasons to group functions together across crates so I'm just going to go module-by-module. This is half of the remaining items from the `std` crate, from O-Z. `panicking::take_hook` has a side effect: it unregisters the current panic hook, returning it. I almost ignored it, but the documentation example shows `let _ = panic::take_hook();`, so following suit I went ahead and added a `#[must_use]`. ```rust std::panicking fn take_hook() -> Box<dyn Fn(&PanicInfo<'_>) + 'static + Sync + Send>; ``` I added these functions that clippy did not flag: ```rust std::path::Path fn starts_with<P: AsRef<Path>>(&self, base: P) -> bool; std::path::Path fn ends_with<P: AsRef<Path>>(&self, child: P) -> bool; std::path::Path fn with_file_name<S: AsRef<OsStr>>(&self, file_name: S) -> PathBuf; std::path::Path fn with_extension<S: AsRef<OsStr>>(&self, extension: S) -> PathBuf; ``` Parent issue: rust-lang#89692 r? `@joshtriplett`
Configuration menu - View commit details
-
Copy full SHA for 455a79a - Browse repository at this point
Copy the full SHA 455a79aView commit details