Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the minimum external LLVM to 11 #90062

Closed
wants to merge 2 commits into from

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Oct 19, 2021

With this change, we'll have stable support for LLVM 11..=13.
For reference, the previous increase to LLVM 10 was #83387.

r? @nagisa @nikic

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 19, 2021
@rust-log-analyzer

This comment has been minimized.

@nikic
Copy link
Contributor

nikic commented Oct 20, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Oct 20, 2021

📌 Commit 5a87d1a has been approved by nikic

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 20, 2021
Update the minimum external LLVM to 11

With this change, we'll have stable support for LLVM 11..=13.
For reference, the previous increase to LLVM 10 was rust-lang#83387.

r? `@nagisa` `@nikic`
@cuviper
Copy link
Member Author

cuviper commented Oct 22, 2021

@rust-lang/wg-llvm How would you all feel about jumping to LLVM 12 right now?

#90042 is struggling with codegen issues in llvm-10, which they also find to be a problem with system llvm-11, but not llvm-12. There's discussion in the zulip 1.57 bootstrap topic. (cc @rust-lang/release)

For my own part, I currently only need LLVM 11 support for Fedora 33, which will be EOL before 1.58 comes out.

@nagisa
Copy link
Member

nagisa commented Oct 22, 2021

I'm comfortable with us maintaining just the current and previous releases of LLVM in general. That has been the case at some points in the past as well. Otherwise requests for support beyond these LLVM versions tend to come from either distributions or, sometimes, people trying to utilize cross-lang LTO.

@cuviper
Copy link
Member Author

cuviper commented Oct 22, 2021

See #90175, and if that's approved, don't forget to r- this one.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 23, 2021
Update the minimum external LLVM to 11

With this change, we'll have stable support for LLVM 11..=13.
For reference, the previous increase to LLVM 10 was rust-lang#83387.

r? `@nagisa` `@nikic`
@matthiaskrgr
Copy link
Member

Failed in a rollup: #90200 (comment)
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 23, 2021
@cuviper
Copy link
Member Author

cuviper commented Oct 23, 2021

Thanks -- pushed a fix in #90175.

@cuviper cuviper closed this Oct 23, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 23, 2021
Update the minimum external LLVM to 12

With this change, we'll have stable support for LLVM 12 and 13.
For reference, the previous increase to LLVM 10 was rust-lang#83387,
and this replaces the pending increase to LLVM 11 in rust-lang#90062.

r? `@nagisa` `@nikic`
@cuviper cuviper deleted the min-llvm-11 branch April 12, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of LLVM_DWP_EXECUTABLE doesn't play nicely with --out-dir
7 participants