Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest Box::pin when Pin::new is used instead #89870

Merged
merged 6 commits into from
Oct 15, 2021
Merged

Suggest Box::pin when Pin::new is used instead #89870

merged 6 commits into from
Oct 15, 2021

Commits on Oct 13, 2021

  1. Fix line length

    @tmandry
    tmandry committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    2c31c31 View commit details
    Browse the repository at this point in the history

  2. Fix incorrect Box::pin suggestion 

    The suggestion checked if Pin<Box<T>> could be coeerced to the expected
type, but did not check predicates created by the coercion. We now
look for predicates that definitely cannot be satisfied before giving
the suggestion.

The suggestion is marked MaybeIncorrect because we allow predicates that
are still ambiguous and can't be proven.
    @tmandry
    tmandry committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    5c14433 View commit details
    Browse the repository at this point in the history

  3. Always check predicates in can_coerce 

    This only changed two tests and I consider both changes an improvement.
    @tmandry
    tmandry committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    485ae9f View commit details
    Browse the repository at this point in the history

  4. Move misplaced comment

    @tmandry
    tmandry committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    156c922 View commit details
    Browse the repository at this point in the history

  5. Exit early if expected type is not an adt

    @tmandry
    tmandry committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    a8558e9 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. Suggest Box::pin when Pin::new is used instead

    @tmandry
    tmandry committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    d18502d View commit details
    Browse the repository at this point in the history