Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Build the compiler with a single CGU #87650

Closed
wants to merge 1 commit into from

Conversation

Aaron1011
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 31, 2021
@Aaron1011
Copy link
Member Author

r? @ghost

@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 31, 2021
@bors
Copy link
Contributor

bors commented Jul 31, 2021

⌛ Trying commit 97f92af with merge b5c1bf9c686c9b4714ff5fbc277f176c2129a1eb...

@bors
Copy link
Contributor

bors commented Jul 31, 2021

☀️ Try build successful - checks-actions
Build commit: b5c1bf9c686c9b4714ff5fbc277f176c2129a1eb (b5c1bf9c686c9b4714ff5fbc277f176c2129a1eb)

@rust-timer
Copy link
Collaborator

Queued b5c1bf9c686c9b4714ff5fbc277f176c2129a1eb with parent 199d1ae, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (b5c1bf9c686c9b4714ff5fbc277f176c2129a1eb): comparison url.

Summary: This change led to significant mixed results 🤷 in compiler performance.

  • Very large regression in instruction counts (up to 14.3% on full builds of inflate-check)
  • Very large improvement in instruction counts (up to -11.3% on incr-unchanged builds of deeply-nested-async-check)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 31, 2021
@the8472
Copy link
Member

the8472 commented Jul 31, 2021

This time instructions might not be painting the whole picture? 🤔

Except for ctfe-stress-4 and rustc max-rss, wall-time, cycles are mostly trending down as opposed their usual mixed results.

@Mark-Simulacrum
Copy link
Member

r? @Aaron1011 until this is ready for review (perfbot will auto remark to -review I think otherwise), happy to review once that happens though!

@inquisitivecrystal inquisitivecrystal added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 24, 2021
@jackh726 jackh726 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2021
@Mark-Simulacrum
Copy link
Member

I'm going to go ahead and close this. I think the perf results don't speak to this being a clear win, and certainly it would be a big hit to our CI times.

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 15, 2023
[WIP] Build `rustc` with a single CGU on x64 Linux

Follow-up attempt to rust-lang#87650. I wonder if anything changed with the addition of LTO.

I also enabled a single CGU only for the actual build of the compiler on CI, so that we can better see the perf. effects on the bootstrap benchmark.
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 15, 2023
[WIP] Build `rustc` with a single CGU on x64 Linux

Follow-up attempt to rust-lang#87650. I wonder if anything changed with the addition of LTO.

I also enabled a single CGU only for the actual build of the compiler on CI, so that we can better see the perf. effects on the bootstrap benchmark.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants