-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Build the compiler with a single CGU #87650
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
r? @ghost |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 97f92af with merge b5c1bf9c686c9b4714ff5fbc277f176c2129a1eb... |
☀️ Try build successful - checks-actions |
Queued b5c1bf9c686c9b4714ff5fbc277f176c2129a1eb with parent 199d1ae, future comparison URL. |
Finished benchmarking try commit (b5c1bf9c686c9b4714ff5fbc277f176c2129a1eb): comparison url. Summary: This change led to significant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @bors rollup=never |
This time instructions might not be painting the whole picture? 🤔 Except for |
r? @Aaron1011 until this is ready for review (perfbot will auto remark to -review I think otherwise), happy to review once that happens though! |
I'm going to go ahead and close this. I think the perf results don't speak to this being a clear win, and certainly it would be a big hit to our CI times. |
[WIP] Build `rustc` with a single CGU on x64 Linux Follow-up attempt to rust-lang#87650. I wonder if anything changed with the addition of LTO. I also enabled a single CGU only for the actual build of the compiler on CI, so that we can better see the perf. effects on the bootstrap benchmark.
[WIP] Build `rustc` with a single CGU on x64 Linux Follow-up attempt to rust-lang#87650. I wonder if anything changed with the addition of LTO. I also enabled a single CGU only for the actual build of the compiler on CI, so that we can better see the perf. effects on the bootstrap benchmark.
No description provided.