Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diagnostics for wrongly ordered keywords in function declaration #87235

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Improve diagnostics for wrongly ordered keywords in function declaration #87235

merged 1 commit into from
Aug 9, 2021

Commits on Aug 2, 2021

  1. Better message for invalid keyword placement in fn 

    After this commit, `unsafe async fn ...` now suggests the `async unsafe` fix
instead of misunderstanding the issue.

This is not perfect for repeated keywords (`const async const`) and for
keywords that are misplaced after `extern "some abi"` because of the way
`check_fn_font_matter` works, but changing it breaks so many tests and
diagnostics it has been judged too high a cost for this PR.
    @poliorcetics
    poliorcetics committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    690cbb7 View commit details
    Browse the repository at this point in the history