-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove specialization from iter::Fuse #86766
Conversation
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
Queuing for a performance run, especially relative to #86765. @bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit dc49dd0 with merge 3685c31a52d407c58e576c060e96a12744df78f8... |
☀️ Try build successful - checks-actions |
Queued 3685c31a52d407c58e576c060e96a12744df78f8 with parent 868c702, future comparison URL. |
Finished benchmarking try commit (3685c31a52d407c58e576c060e96a12744df78f8): comparison url. Summary: This change led to significant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Closing in favor of #86765. |
Fixes #85863 by removing
Fuse
's specialization altogether.