feature flag: add feature flag type_changing_struct_update for implementation of RFC #2528
#86646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
This was referenced Jun 26, 2021
JohnCSimon
added
S-waiting-on-author
|
Ping from triage: |
bstrie
added
S-waiting-on-author
|
@kolharsam Ping from triage, CI is still red here. Mind fixing it? |
camelid
added
S-waiting-on-author
camelid
reviewed
Sep 2, 2021
| @@ -666,6 +666,10 @@ declare_features! ( | |||
| /// Allows qualified paths in struct expressions, struct patterns and tuple struct patterns. | |||
| (active, more_qualified_paths, "1.54.0", Some(80080), None), | |||
|
|
|||
| /// Allows creation of instances of a struct by moving fields that have | |||
| /// not changed from prior instances of the same struct (RFC #2528) | |||
| (active, type_changing_struct_update, "1.55.0", Some(86618), None) | |||
There was a problem hiding this comment.
This just needs a trailing comma to fix CI.
There was a problem hiding this comment.
Also, the version number will need to be updated, right?
There was a problem hiding this comment.
Yes, I believe it should be updated to 1.57.0 (because 1.56.0 is about to be promoted to beta).
JohnCSimon
added
the
S-inactive
|
Triage: @kolharsam I'm closing this as inactive, please feel free to reopen the PR when you're ready to continue. Thanks. |
crlf0710
added
the
F-type-changing-struct-update
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 22, 2021
…ackh726 add feature flag for `type_changing_struct_update` This implements the PR0 part of the mentoring notes within rust-lang#86618. overrides the previous inactive rust-lang#86646 pr. r? `@nikomatsakis`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 22, 2021
…ackh726 add feature flag for `type_changing_struct_update` This implements the PR0 part of the mentoring notes within rust-lang#86618. overrides the previous inactive rust-lang#86646 pr. r? ``@nikomatsakis``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 23, 2021
…ackh726 add feature flag for `type_changing_struct_update` This implements the PR0 part of the mentoring notes within rust-lang#86618. overrides the previous inactive rust-lang#86646 pr. r? ```@nikomatsakis```
Dylan-DPC
removed
the
S-inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feature flag:
type_changing_struct_updatewith regards to the implementation of RFC rust-lang/rfcs#2528.The implementation issue can be found here: #86618