-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustfix update #86210
Rustfix update #86210
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #86207) made this pull request unmergeable. Please resolve the merge conflicts. |
Hm, am I correct that the changes in this PR have no bearing on the rustfix users observe in use? That comes from cargo, and is not being updated here, right? It seems like our compiletest should use the same version as users will see -- I'm surprised to see only one get updated here. Maybe it makes sense to add a tidy check or otherwise assert the two are the same? |
Yea, this is only for running compiletest tests. The reason this is separate is because #86207 needed to be merged to unblock another PR, and there was some desire to unblock it before beta branched. I didn't want to make the PR wait for these updates to get reviewed and merged. I went ahead and added a small check to tidy. rustfix semver-incompatible changes only happen once every few years, so it's not too common. The tidy check can be removed if it is a problem. |
Sounds good, thanks for adding the tidy check. @bors r+ |
📌 Commit 35bf1be has been approved by |
☀️ Test successful - checks-actions |
This updates to rustfix 0.6.0. One of the key changes here is rust-lang/rustfix#195 which changes rustfix to apply multi-part suggestions. One of the tests needs to updated because there are some overlapping suggestions which rustfix cannot handle. The solution is to only apply the machine-applicable suggestions to avoid the overlapping issue.
This also includes a minor change to compiletest to provide better error messages with rustfix.