Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 12 pull requests #85328

Merged
merged 33 commits into from
May 15, 2021
Merged

Commits on May 5, 2021

  1. Configuration menu
    Copy the full SHA
    0aa2844 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. Fix typo in comment

    missing space in "rootseparator"
    andrewhalle committed May 12, 2021
    Configuration menu
    Copy the full SHA
    3c06f00 View commit details
    Browse the repository at this point in the history
  2. dbg macro: Discuss use in tests, and slightly clarify

    Signed-off-by: Ian Jackson <[email protected]>
    ijackson committed May 12, 2021
    Configuration menu
    Copy the full SHA
    a173518 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Spanview needs the relevant body_span used for coverage

    The coverage body_span doesn't always match the function body_span.
    richkadel committed May 13, 2021
    Configuration menu
    Copy the full SHA
    e354cca View commit details
    Browse the repository at this point in the history
  2. Simplified body_span and filtered span code

    Some code cleanup extracted from future (but unfinished) commit to fix
    coverage in attr macro functions.
    richkadel committed May 13, 2021
    Configuration menu
    Copy the full SHA
    31f523f View commit details
    Browse the repository at this point in the history
  3. coverageinfo query needs to use the same MIR as codegen

    I ran into an error trying to fix dead block coverage and realized the
    `coverageinfo` query is getting a different MIR compared to the
    codegenned MIR, which can sometimes be a problem during mapgen.
    
    I changed that query to use the `InstandeDef` (which includes the
    generic parameter substitutions, prosibly specific to const params)
    instead of the `DefId` (without unknown/default const substitutions).
    richkadel committed May 13, 2021
    Configuration menu
    Copy the full SHA
    aed8ef5 View commit details
    Browse the repository at this point in the history
  4. Miner code formatting

    ayushmishra2005 committed May 13, 2021
    Configuration menu
    Copy the full SHA
    0cee527 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    267450a View commit details
    Browse the repository at this point in the history
  6. swap function order for better read flow

    When having the order
    
    ```
    foo.bar(); // we can now use this method since i32 implements the Foo trait
    
    [...]
    
    impl Foo for i32
    ```
    
    the `// we can now use this method` comment is less clear to me.
    RafaelKr authored May 13, 2021
    Configuration menu
    Copy the full SHA
    a56d0e2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    812994e View commit details
    Browse the repository at this point in the history
  8. Change "etc." to "and similar"

    Co-authored-by: Josh Triplett <[email protected]>
    ijackson and joshtriplett authored May 13, 2021
    Configuration menu
    Copy the full SHA
    b36a316 View commit details
    Browse the repository at this point in the history
  9. Use my real name

    camelid committed May 13, 2021
    Configuration menu
    Copy the full SHA
    4672520 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2021

  1. Configuration menu
    Copy the full SHA
    34055a9 View commit details
    Browse the repository at this point in the history
  2. Addressed PR coments

    ayushmishra2005 committed May 14, 2021
    Configuration menu
    Copy the full SHA
    27defcd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    766de3a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0c02338 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7eb95cd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    dfc8b60 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2021

  1. Fix eslint errors

    GuillaumeGomez committed May 15, 2021
    Configuration menu
    Copy the full SHA
    ccabd4e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    18b7c0a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    67d8d18 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#84461 - jyn514:remove-strip-item, r=Guillau…

    …meGomez
    
    rustdoc: Remove unnecessary `StripItem` wrapper
    GuillaumeGomez authored May 15, 2021
    Configuration menu
    Copy the full SHA
    9682fa9 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#85067 - Stupremee:minimize-amount-of-fake-d…

    …efids, r=jyn514,GuillaumeGomez
    
    Minimize amount of fake `DefId`s used in rustdoc
    
    Follow up from rust-lang#84707, which minimizes the amount of fake defids to the smallest amount possible. Every `FakeDefId` that is now used in the rustdoc library must be preserved and can not be replaced with a normal `DefId`.
    GuillaumeGomez authored May 15, 2021
    Configuration menu
    Copy the full SHA
    b68d543 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#85207 - andrewhalle:typo-rootseparator, r=k…

    …ennytm
    
    Fix typo in comment
    
    missing space in "rootseparator"
    GuillaumeGomez authored May 15, 2021
    Configuration menu
    Copy the full SHA
    c4f81c1 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#85215 - richkadel:ice-fixes-minus-dead-bloc…

    …ks, r=tmandry
    
    coverage bug fixes and some refactoring
    
    This replaces the relevant commits (2 and 3) from PR rust-lang#85082, and also corrects an error querying for coverageinfo.
    
    1. `coverageinfo` query needs to use the same MIR as codegen
    
    I ran into an error trying to fix dead block coverage and realized the
    `coverageinfo` query is getting a different MIR compared to the
    codegenned MIR, which can sometimes be a problem during mapgen.
    
    I changed that query to use the `InstandeDef` (which includes the
    generic parameter substitutions, prosibly specific to const params)
    instead of the `DefId` (without unknown/default const substitutions).
    
    2. Simplified body_span and filtered span code
    
      Some code cleanup extracted from future (but unfinished) commit to fix
      coverage in attr macro functions.
    
    3. Spanview needs the relevant body_span used for coverage
    
    The coverage body_span doesn't always match the function body_span.
    
    r? ```@tmandry```
    GuillaumeGomez authored May 15, 2021
    Configuration menu
    Copy the full SHA
    e611e64 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#85221 - ijackson:dbg-doc-re-tests, r=joshtr…

    …iplett
    
    dbg macro: Discuss use in tests, and slightly clarify
    
    As discussed in a tangent in rust-lang#82778.
    
    I chose to use [semantic newlines](https://rhodesmill.org/brandon/2012/one-sentence-per-line/) in the source text but I don't mind reformatting it.
    GuillaumeGomez authored May 15, 2021
    Configuration menu
    Copy the full SHA
    5a8619b View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#85246 - ayushmishra2005:minor-reactoring, r…

    …=petrochenkov
    
    Miner code formatting
    GuillaumeGomez authored May 15, 2021
    Configuration menu
    Copy the full SHA
    57aa0d8 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#85253 - RafaelKr:patch-1, r=varkor

    swap function order for better read flow
    
    I was reading this error message for the first time.
    
    I was a little bit confused when reading that part:
    ```
    foo.bar(); // we can now use this method since i32 implements the Foo trait
    ```
    
    At the time I was reading `// we can now use this method` I wasn't sure why. It only made sense when reading on. So swapping these parts results in a better read flow.
    GuillaumeGomez authored May 15, 2021
    Configuration menu
    Copy the full SHA
    36b3c28 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#85256 - GuillaumeGomez:fix-implementors-dis…

    …play, r=notriddle
    
    Fix display for "implementors" section
    
    Just saw this problem when going through docs:
    
    ![Screenshot from 2021-05-13 15-20-52](https://user-images.githubusercontent.com/3050060/118131978-766fc180-b3ff-11eb-86a8-7f6d22afa675.png)
    
    This fix puts it back to normal:
    
    ![Screenshot from 2021-05-13 15-23-29](https://user-images.githubusercontent.com/3050060/118132006-7e2f6600-b3ff-11eb-9985-025a7b7c5216.png)
    
    You can see it on the `TryFrom` page for example.
    
    r? ```@Nemo157```
    GuillaumeGomez authored May 15, 2021
    Configuration menu
    Copy the full SHA
    5bfbabc View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    1a926bf View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#85278 - ayushmishra2005:code-refactoring, r…

    …=jackh726
    
    Improve match statements
    GuillaumeGomez authored May 15, 2021
    Configuration menu
    Copy the full SHA
    cd3d166 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    2b5ef25 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#85323 - GuillaumeGomez:fix-eslint-errors, r…

    …=jsha
    
    Fix eslint errors
    
    I cherry-picked the two non-CI commits from rust-lang#85285.
    
    r? ```@jsha```
    GuillaumeGomez authored May 15, 2021
    Configuration menu
    Copy the full SHA
    46bc552 View commit details
    Browse the repository at this point in the history