Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest lint groups #84959

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Suggest lint groups #84959

merged 1 commit into from
Jul 20, 2021

Conversation

camsteffen
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 5, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@camsteffen camsteffen force-pushed the lint-suggest-group branch from 0aa48c3 to 25c66a1 Compare May 5, 2021 18:11
@crlf0710 crlf0710 added A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. A-diagnostics Area: Messages for errors, warnings, and lints labels May 22, 2021
@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2021
@camsteffen
Copy link
Contributor Author

@estebank friendly bump

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jul 19, 2021

📌 Commit 25c66a1 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2021
@bors
Copy link
Contributor

bors commented Jul 20, 2021

⌛ Testing commit 25c66a1 with merge c9aa259...

@bors
Copy link
Contributor

bors commented Jul 20, 2021

☀️ Test successful - checks-actions
Approved by: estebank
Pushing c9aa259 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 20, 2021
@bors bors merged commit c9aa259 into rust-lang:master Jul 20, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@estebank estebank

Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.

Poor suggestion on missing colon from lint path flag
9 participants
@camsteffen @rust-highfive @rust-log-analyzer @estebank @bors @JohnTitor @crlf0710 @JohnCSimon @rustbot