Compiler error messages: reduce assertiveness of message E0384 #84172
Conversation
This message is emitted as guidance by the compiler when a developer attempts to reassign a value to an immutable variable. Following the message will always currently work, but it may not always be the best course of action; following the 'consider ...' messaging pattern provides a hint to the developer that it could be wise to explore other alternatives.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Thanks! |
|
📌 Commit 0174dd6 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 0174dd6 with merge c091589eabb1cd80ff2666d7441dbd88740daf3c... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The failure looks spurious and unrelated, @bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 0174dd6 with merge 046bb46807fe7180d118c1513ddc27c330951006... |
|
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-review
|
Thanks @petrochenkov; I did notice that a very similar error to #84172 (comment) was also reported at #83610 (comment) (cc @bjorn3) - perhaps there's a bug to find in the build process somewhere? |
|
@bors retry |
bors
added
S-waiting-on-bors
|
@bors r+ |
|
📌 Commit ff47e97 has been approved by |
Rollup of 4 pull requests Successful merges: - rust-lang#83337 (rustdoc: Hide item contents, not items) - rust-lang#83944 (Fix a couple resolve bugs from binder refactor) - rust-lang#84145 (Address comments for vecdeque_binary_search rust-lang#78021) - rust-lang#84172 (Compiler error messages: reduce assertiveness of message E0384) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This message is emitted as guidance by the compiler when a developer attempts to reassign a value to an immutable variable. Following the message will always currently work, but it may not always be the best course of action; following the 'consider ...' messaging pattern provides a hint to the developer that it could be wise to explore other alternatives.
Resolves #84144