Treat header as first paragraph for shortened markdown descriptions #82962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"The Rust Standard LibraryThe Rust Standard Library is the …" is an awful description.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
It's kinda silly using serde seq for fixed-length stuff.
notriddle
force-pushed
the
cleanup-index
branch
from
97a9463
to
66b6504
Compare
jyn514
reviewed
Mar 10, 2021
| let mut seq = serializer.serialize_seq(None)?; | ||
| seq.serialize_element(&self.ty.name)?; | ||
| let x: ItemType = self.kind.into(); | ||
| seq.serialize_element(&x)?; | ||
| seq.end() | ||
| (&self.ty.name, ItemType::from(self.kind)).serialize(serializer) |
There was a problem hiding this comment.
It shouldn't actually cause any behaviour changes. It just removes lines of code.
jyn514
added
T-rustdoc
GuillaumeGomez
approved these changes
Mar 10, 2021
|
@bors r+ |
|
📌 Commit 66b6504 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 10, 2021
Rollup of 9 pull requests Successful merges: - rust-lang#81309 (always eagerly eval consts in Relate) - rust-lang#82217 (Edition-specific preludes) - rust-lang#82807 (rustdoc: Remove redundant enableSearchInput function) - rust-lang#82924 (WASI: Switch to crt1-command.o to enable support for new-style commands) - rust-lang#82949 (Do not attempt to unlock envlock in child process after a fork.) - rust-lang#82955 (fix: wrong word) - rust-lang#82962 (Treat header as first paragraph for shortened markdown descriptions) - rust-lang#82976 (fix error message for copy(_nonoverlapping) overflow) - rust-lang#82977 (Rename `Option::get_or_default` to `get_or_insert_default`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"The Rust Standard LibraryThe Rust Standard Library is the …" is an awful description.