Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unix: Non-mutable bufs in send_vectored_with_ancillary_to #82589

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

LinkTed
Copy link
Contributor

@LinkTed LinkTed commented Feb 27, 2021

This is the same PR as #79753. It was closed because of inactivity. Therefore, I create a new one. @lukaslihotzki

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2021
Change the arguments of `send_vectored_with_ancillary` and
`send_vectored_with_ancillary_to` to take an non-mutable bufs.
@joshtriplett
Copy link
Member

This looks good to me. I'm reasonably confident that sendmsg does not modify its buffer. I can imagine some kind of future non-standard sendmsg flag that causes it to modify the structure (e.g. changing lengths to report something back), but if that ever happens, we could filter such flags and offer a separate method for that.

@bors r+

@bors
Copy link
Contributor

bors commented Mar 1, 2021

📌 Commit 9e4e739 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 2, 2021
unix: Non-mutable bufs in send_vectored_with_ancillary_to

This is the same PR as [rust-lang#79753](rust-lang#79753). It was closed because of inactivity. Therefore, I create a new one. ``@lukaslihotzki``
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 3, 2021
unix: Non-mutable bufs in send_vectored_with_ancillary_to

This is the same PR as [rust-lang#79753](rust-lang#79753). It was closed because of inactivity. Therefore, I create a new one. ```@lukaslihotzki```
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2021
Rollup of 10 pull requests

Successful merges:

 - rust-lang#81223 ([rustdoc] Generate redirect map file)
 - rust-lang#82439 (BTree: fix untrue safety)
 - rust-lang#82469 (Use a crate to produce rustdoc tree comparisons instead of the `diff` command)
 - rust-lang#82589 (unix: Non-mutable bufs in send_vectored_with_ancillary_to)
 - rust-lang#82689 (meta: Notify Zulip for rustdoc nominated issues)
 - rust-lang#82695 (Revert non-power-of-two vector restriction)
 - rust-lang#82706 (use outer_expn_data() instead of outer_expn().expn_data())
 - rust-lang#82710 (FloatToInit: Replacing round_unchecked_to --> to_int_unchecked)
 - rust-lang#82712 (Remove unnecessary conditional `cfg(target_os)` for `redox` and `vxworks`)
 - rust-lang#82713 (Update cargo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b16b682 into rust-lang:master Mar 3, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants