Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline try_get_cached #82197

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Inline try_get_cached #82197

merged 1 commit into from
Feb 17, 2021

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Feb 16, 2021

No description provided.

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 16, 2021
@tmiasko
Copy link
Contributor Author

tmiasko commented Feb 16, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 16, 2021
@bors
Copy link
Contributor

bors commented Feb 16, 2021

⌛ Trying commit db36db2 with merge 47948b92152f8dec0cdf064a17c3f92f52e45543...

@bors
Copy link
Contributor

bors commented Feb 16, 2021

☀️ Try build successful - checks-actions
Build commit: 47948b92152f8dec0cdf064a17c3f92f52e45543 (47948b92152f8dec0cdf064a17c3f92f52e45543)

@rust-timer
Copy link
Collaborator

Queued 47948b92152f8dec0cdf064a17c3f92f52e45543 with parent 9d3deed, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (47948b92152f8dec0cdf064a17c3f92f52e45543): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 16, 2021
@cjgillot
Copy link
Contributor

I guess we found the guilty party.
@bors r+

@bors
Copy link
Contributor

bors commented Feb 16, 2021

📌 Commit db36db2 has been approved by cjgillot

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2021
@bors
Copy link
Contributor

bors commented Feb 17, 2021

⌛ Testing commit db36db2 with merge 381b13728edeb1d036b5f5c2e3547503bff2b74a...

@bors
Copy link
Contributor

bors commented Feb 17, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 17, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@jyn514
Copy link
Member

jyn514 commented Feb 17, 2021

Run src/ci/scripts/install-awscli.sh
Reading package lists...
E: Encountered a section with no Package: header
E: Problem with MergeList /var/lib/apt/lists/storage.googleapis.com_bazel-apt_dists_stable_jdk1.8_binary-amd64_Packages
E: The package lists or status file could not be parsed or opened.

Seems spurious? cc @rust-lang/infra

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2021
@bors
Copy link
Contributor

bors commented Feb 17, 2021

⌛ Testing commit db36db2 with merge ee88f46...

@bors
Copy link
Contributor

bors commented Feb 17, 2021

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing ee88f46 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 17, 2021
@bors bors merged commit ee88f46 into rust-lang:master Feb 17, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 17, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at ee88f46bb Auto merge of #82197 - tmiasko:try-get-cached, r=cjgillot
##[group]Run src/ci/publish_toolstate.sh
src/ci/publish_toolstate.sh
env:
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  DEPLOY_BUCKET: rust-lang-ci2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
  CACHE_DOMAIN: ci-caches.rust-lang.org
  TOOLSTATE_REPO_ACCESS_TOKEN: ***
##[endgroup]
Cloning into 'rust-toolstate'...
/home/runner/work/rust/rust/src/tools/publish_toolstate.py:121: DeprecationWarning: 'U' mode is deprecated
📣 Toolstate changed by rust-lang/rust#82197!

Tested on commit rust-lang/rust@ee88f46bb5e27c4d9f30326e69ff2298dcbeecb1.
Direct link to PR: <https://github.com/rust-lang/rust/pull/82197>

🎉 miri on windows: test-fail → test-pass (cc @RalfJung @eddyb @oli-obk).
🎉 miri on linux: test-fail → test-pass (cc @RalfJung @eddyb @oli-obk).

  with open(path, 'rU') as f:
Traceback (most recent call last):
  File "/home/runner/work/rust/rust/src/tools/publish_toolstate.py", line 338, in <module>
    response = urllib2.urlopen(urllib2.Request(
  File "/usr/lib/python3.8/urllib/request.py", line 222, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.8/urllib/request.py", line 522, in open
    req = meth(req)
  File "/usr/lib/python3.8/urllib/request.py", line 1281, in do_request_
    raise TypeError(msg)
TypeError: POST data should be bytes, an iterable of bytes, or a file object. It cannot be of type str.
##[error]Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants