-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid memory allocation when removing dead blocks #81470
Conversation
Use `reachable_as_bitset` to reuse a bitset from the traversal rather than allocating it seprately. Additionally check if there are any unreachable blocks before proceeding.
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. |
⌛ Trying commit dc6ec35 with merge f4eaeac6891ab5e03034bb6f220380a7bd667d5c... |
☀️ Try build successful - checks-actions |
Queued f4eaeac6891ab5e03034bb6f220380a7bd667d5c with parent 643a79a, future comparison URL. @rustbot label: +S-waiting-on-perf |
Finished benchmarking try commit (f4eaeac6891ab5e03034bb6f220380a7bd667d5c): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
@bors r+ |
📌 Commit dc6ec35 has been approved by |
☀️ Test successful - checks-actions |
Use
reachable_as_bitset
to reuse a bitset from the traversal ratherthan allocating it seprately. Additionally check if there are any
unreachable blocks before proceeding.