tidy: allow arbitrary spaces between // and NOTE #8006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`make tidy` now detects `//NOTE`, `// NOTE`, etc. This also removes the extra empty line emitted after each warning. Fixes rust-lang#6060
bors
added a commit
that referenced
this pull request
Jul 24, 2013
Hello, I made a tiny change to `tidy.py` so that it uses a regexp to find `// NOTE` comments. I could not find an easy way to write an automated test for this but if this is needed and possible I'd be happy to write one. Please note that it also removes extra empty lines that appear after each of these warnings (I believe that there were not wanted). On the performance side, `make tidy` is now a bit slower (running it 10 times in a row takes 71s on my machine, 65s before) but I don't think that it is performance sensitive. Thanks!
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 2, 2021
…ffen apply iter_cloned_collect to collect() using copied() fix: rust-lang#6703 changelog: apply `iter_cloned_collect` to `collect()` using`copied()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I made a tiny change to
tidy.pyso that it uses a regexp to find// NOTEcomments. I could not find an easy way to write an automated test for this but if this is needed and possible I'd be happy to write one.Please note that it also removes extra empty lines that appear after each of these warnings (I believe that there were not wanted).
On the performance side,
make tidyis now a bit slower (running it 10 times in a row takes 71s on my machine, 65s before) but I don't think that it is performance sensitive.Thanks!