make redundant StorageLive UB #79931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
RalfJung
changed the title
RalfJung
force-pushed
the
no-redundant-storage-live
branch
from
0eb906c to
41c56f5
Compare
|
r=me with rustfmt |
RalfJung
force-pushed
the
no-redundant-storage-live
branch
from
41c56f5 to
78deacc
Compare
|
@bors r=oli-obk |
|
📌 Commit 78deacc has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 78deacc with merge b65fa51fe6201a73dbf25f2d0bc99e65faa4175d... |
jyn514
added
A-const-eval
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interesting behavior of StorageLive in loops (#42371) has been fixed, so we can now finally make it a hard error to mark a local as live that is already live. :)
r? @oli-obk
Fixes #42371