Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower patterns before using the bound variable #79362

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Lower patterns before using the bound variable #79362

merged 2 commits into from
Nov 26, 2020

Conversation

cjgillot
Copy link
Contributor

So as to avoid having to lower patterns twice.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2020
@camelid camelid added the A-patterns Relating to patterns and pattern matching label Nov 23, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Nov 26, 2020

Just for clarity, this is not about lowering patterns twice, it is about lowering node ids of patterns twice?

I don't quite see how the first and second commit are related to each other, can you explain that a bit?

@cjgillot
Copy link
Contributor Author

Currently, the AST is traversed once to collect and lower all the Pat's node ids. Only later is the AST traversed for the actual lowering of the tree.
This was required because lowering a use of a local variable (introduced by a Pat) requires this Pat's node id to already be lowered.
By changing the lowering order (first commit), the preliminary lowering of node ids is not necessary any more (second commit).

@oli-obk
Copy link
Contributor

oli-obk commented Nov 26, 2020

Thanks!

@bors r+

r? @oli-obk

@bors
Copy link
Contributor

bors commented Nov 26, 2020

📌 Commit 27c60ba has been approved by oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned eddyb Nov 26, 2020
@bors
Copy link
Contributor

bors commented Nov 26, 2020

🌲 The tree is currently closed for pull requests below priority 500, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2020
This was referenced Nov 26, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 26, 2020
@bors
Auto merge of rust-lang#79441 - jonas-schievink:rollup-l9v00bl, r=jon…
0beba93 
…as-schievink

Rollup of 10 pull requests

Successful merges:

 - rust-lang#77758 (suggest turbofish syntax for uninferred const arguments)
 - rust-lang#79000 (Move lev_distance to rustc_ast, make non-generic)
 - rust-lang#79362 (Lower patterns before using the bound variable)
 - rust-lang#79365 (Upgrades the coverage map to Version 4)
 - rust-lang#79402 (Fix typos)
 - rust-lang#79412 (Clean up rustdoc tests by removing unnecessary features)
 - rust-lang#79413 (Fix persisted doctests on Windows / when using workspaces)
 - rust-lang#79420 (Fixes a word typo in librustdoc)
 - rust-lang#79421 (Fix docs formatting for `thir::pattern::_match`)
 - rust-lang#79428 (Fixup compiler docs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 85c11de into rust-lang:master Nov 26, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 26, 2020
@cjgillot cjgillot deleted the relou branch November 26, 2020 17:35
@SNCPlay42 SNCPlay42 mentioned this pull request Nov 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
A-patterns Relating to patterns and pattern matching S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
7 participants
@cjgillot @rust-highfive @oli-obk @bors @eddyb @camelid @rustbot