Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_resolve: Make macro_rules scope chain compression lazy #79034

Merged
merged 1 commit into from
Nov 15, 2020
Merged

rustc_resolve: Make macro_rules scope chain compression lazy #79034

merged 1 commit into from
Nov 15, 2020

Conversation

petrochenkov
Copy link
Contributor

As suggested in #78826 (comment).

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 13, 2020
@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Nov 13, 2020

⌛ Trying commit ac4c1f5 with merge badbb4dbfefe819f679a52ff733c2ef511b27ca5...

@bors
Copy link
Contributor

bors commented Nov 13, 2020

☀️ Try build successful - checks-actions
Build commit: badbb4dbfefe819f679a52ff733c2ef511b27ca5 (badbb4dbfefe819f679a52ff733c2ef511b27ca5)

@rust-timer
Copy link
Collaborator

Queued badbb4dbfefe819f679a52ff733c2ef511b27ca5 with parent 89bce3e, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (badbb4dbfefe819f679a52ff733c2ef511b27ca5): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-perf

@petrochenkov
Copy link
Contributor Author

@bors rollup-

@eddyb
Copy link
Member

eddyb commented Nov 14, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Nov 14, 2020

📌 Commit ac4c1f5 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2020
@jonas-schievink jonas-schievink mentioned this pull request Nov 14, 2020
Closed
@jonas-schievink jonas-schievink mentioned this pull request Nov 14, 2020
Closed
@jonas-schievink jonas-schievink mentioned this pull request Nov 14, 2020
Closed
@jonas-schievink jonas-schievink mentioned this pull request Nov 15, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2020
@bors
Auto merge of rust-lang#79070 - jonas-schievink:rollup-wacn2b8, r=jon…
5fab31e 
…as-schievink

Rollup of 13 pull requests

Successful merges:

 - rust-lang#77802 (Allow making `RUSTC_BOOTSTRAP` conditional on the crate name)
 - rust-lang#79004 (Add `--color` support to bootstrap)
 - rust-lang#79005 (cleanup: Remove `ParseSess::injected_crate_name`)
 - rust-lang#79016 (Make `_` an expression, to discard values in destructuring assignments)
 - rust-lang#79019 (astconv: extract closures into a separate trait)
 - rust-lang#79026 (Implement BTreeMap::retain and BTreeSet::retain)
 - rust-lang#79031 (Validate that locals have a corresponding `LocalDecl`)
 - rust-lang#79034 (rustc_resolve: Make `macro_rules` scope chain compression lazy)
 - rust-lang#79036 (Move Steal to rustc_data_structures.)
 - rust-lang#79041 (Rename clean::{ItemEnum -> ItemKind}, clean::Item::{inner -> kind})
 - rust-lang#79058 (Move likely/unlikely argument outside of invisible unsafe block)
 - rust-lang#79059 (Print 'checking cranelift artifacts' to easily separate it from other artifacts)
 - rust-lang#79063 (Update rustfmt to v1.4.26)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b0178f4 into rust-lang:master Nov 15, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb eddyb approved these changes

Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
6 participants
@petrochenkov @rust-highfive @rust-timer @bors @eddyb @rustbot