Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 7 pull requests #78974

Closed
wants to merge 28 commits into from
Closed

Rollup of 7 pull requests #78974

wants to merge 28 commits into from

Commits on Nov 5, 2020

  1. Add shortcut for theme picker menu

    @GuillaumeGomez
    GuillaumeGomez committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    8b20e9b View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2020

  1. Consider mutable ident binding patterns to be simple 

    This should fix `rustdoc` rendering of by-value mutable arguments in
`async fn` contexts.
    @ebkalderon @jyn514
    ebkalderon authored and jyn514 committed Nov 8, 2020
    Configuration menu
    Copy the full SHA
    1216432 View commit details
    Browse the repository at this point in the history

  2. Don't reuse bindings for ref mut 

    Reusing bindings causes errors later in lowering:

```
 error[E0596]: cannot borrow `vec` as mutable, as it is not declared as mutable
  --> /checkout/src/test/ui/async-await/argument-patterns.rs:12:20
   |
LL | async fn b(n: u32, ref mut vec: A) {
   |                    ^^^^^^^^^^^
   |                    |
   |                    cannot borrow as mutable
   |                    help: consider changing this to be mutable: `mut vec`
```
    @jyn514
    jyn514 committed Nov 8, 2020
    Configuration menu
    Copy the full SHA
    26b11d6 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2020

  1. const param macro test

    @lcnr
    lcnr committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    d76cdb0 View commit details
    Browse the repository at this point in the history

  2. add generic param mismatch test

    @lcnr
    lcnr committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    359031e View commit details
    Browse the repository at this point in the history

  3. add macro_rules test regarding braces

    @lcnr
    lcnr committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    dd78188 View commit details
    Browse the repository at this point in the history

  4. add associated type bounds test

    @lcnr
    lcnr committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    a8310e2 View commit details
    Browse the repository at this point in the history

  5. exhaustively enumerate all values of a const param

    @lcnr
    lcnr committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    19a3fe6 View commit details
    Browse the repository at this point in the history

  6. try referencing outer params

    @lcnr
    lcnr committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    a30b28e View commit details
    Browse the repository at this point in the history

  7. const param in async

    @lcnr
    lcnr committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    de1ebbb View commit details
    Browse the repository at this point in the history

  8. add test for where clauses mentioning const params

    @lcnr
    lcnr committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    4b5cd04 View commit details
    Browse the repository at this point in the history

  9. add cross crate test

    @lcnr
    lcnr committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    f4790ec View commit details
    Browse the repository at this point in the history

  10. Handle and test wildcard arguments

    @jyn514
    jyn514 committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    96793d3 View commit details
    Browse the repository at this point in the history

  11. Improve the page title switch handling between search and doc

    @GuillaumeGomez
    GuillaumeGomez committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    46c921d View commit details
    Browse the repository at this point in the history

  12. Don't print thread ids and names in tracing logs 

    Before:

```
2:rustc INFO rustc_interface::passes Pre-codegen
2:rustcTy interner             total           ty lt ct all
2:rustc    Adt               :   1078 81.3%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Array             :      1  0.1%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Slice             :      1  0.1%,  0.0%   0.0%  0.0%  0.0%
2:rustc    RawPtr            :      2  0.2%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Ref               :      4  0.3%,  0.1%   0.1%  0.0%  0.0%
2:rustc    FnDef             :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    FnPtr             :     76  5.7%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Placeholder       :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Generator         :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    GeneratorWitness  :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Dynamic           :      3  0.2%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Closure           :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Tuple             :     13  1.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Bound             :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Param             :    146 11.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Infer             :      2  0.2%,  0.1%   0.0%  0.0%  0.0%
2:rustc    Projection        :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Opaque            :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Foreign           :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc                  total   1326         0.2%   0.1%  0.0%  0.0%
2:rustcInternalSubsts interner: rust-lang#437
2:rustcRegion interner: rust-lang#355
2:rustcStability interner: #1
2:rustcConst Stability interner: #0
2:rustcAllocation interner: #0
2:rustcLayout interner: #0
```

After:

```
 INFO rustc_interface::passes Post-codegen
Ty interner             total           ty lt ct all
    Adt               :   1078 81.3%,  0.0%   0.0%  0.0%  0.0%
    Array             :      1  0.1%,  0.0%   0.0%  0.0%  0.0%
    Slice             :      1  0.1%,  0.0%   0.0%  0.0%  0.0%
    RawPtr            :      2  0.2%,  0.0%   0.0%  0.0%  0.0%
    Ref               :      4  0.3%,  0.1%   0.1%  0.0%  0.0%
    FnDef             :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
    FnPtr             :     76  5.7%,  0.0%   0.0%  0.0%  0.0%
    Placeholder       :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
    Generator         :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
    GeneratorWitness  :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
    Dynamic           :      3  0.2%,  0.0%   0.0%  0.0%  0.0%
    Closure           :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
    Tuple             :     13  1.0%,  0.0%   0.0%  0.0%  0.0%
    Bound             :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
    Param             :    146 11.0%,  0.0%   0.0%  0.0%  0.0%
    Infer             :      2  0.2%,  0.1%   0.0%  0.0%  0.0%
    Projection        :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
    Opaque            :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
    Foreign           :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
                  total   1326         0.2%   0.1%  0.0%  0.0%
InternalSubsts interner: rust-lang#437
Region interner: rust-lang#355
Stability interner: #1
Const Stability interner: #0
Allocation interner: #0
Layout interner: #0
```
    @jyn514
    jyn514 committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    9cf8a49 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. Enable thread names in debug logging only for parallel_compiler

    @jyn514
    jyn514 committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    6e9ed8b View commit details
    Browse the repository at this point in the history

  2. add rustdoc test

    @lcnr
    lcnr committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    7d9f815 View commit details
    Browse the repository at this point in the history

  3. add error-in-impl-trait const generics test

    @lcnr
    lcnr committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    a9eacf3 View commit details
    Browse the repository at this point in the history

  4. Add test default_function_param

    @eopb
    eopb committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    ad7f330 View commit details
    Browse the repository at this point in the history

  5. default_trait_param

    @eopb
    eopb committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    1d3f9d0 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. Update books

    @ehuss
    ehuss committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    a8bc954 View commit details
    Browse the repository at this point in the history

  2. Rollup merge of rust-lang#76730 - ebkalderon:rustdoc-fix-mut-args-asy… 

    …nc-fn, r=tmandry

Fix rustdoc rendering of by-value mutable arguments in async fn

r? `@jyn514`

Fixes rust-lang#76517.
    @GuillaumeGomez
    GuillaumeGomez authored Nov 12, 2020
    Configuration menu
    Copy the full SHA
    25fd89a View commit details
    Browse the repository at this point in the history

  3. Rollup merge of rust-lang#78773 - GuillaumeGomez:theme-picker-shortcu… 

    …t, r=jyn514

Add shortcut for theme picker menu

Follow-up of rust-lang#78584

Just like you can focus the search input by pressing "S", you can now access the theme picker menu by pressing "T" and navigate through the options only using the keyboard.

cc `@notriddle`

r? `@jyn514`
    @GuillaumeGomez
    GuillaumeGomez authored Nov 12, 2020
    Configuration menu
    Copy the full SHA
    7305584 View commit details
    Browse the repository at this point in the history

  4. Rollup merge of rust-lang#78916 - lcnr:const-generics-tests, r=varkor 

    extend const generics test suite

should implement most of rust-lang#78433, especially all parts of [the hackmd](https://hackmd.io/WnFmN4MjRCqAjGmYfYcu2A?view) which I did not explicitly mention in that issue.

r? `@varkor`
    @GuillaumeGomez
    GuillaumeGomez authored Nov 12, 2020
    Configuration menu
    Copy the full SHA
    b31c678 View commit details
    Browse the repository at this point in the history

  5. Rollup merge of rust-lang#78921 - GuillaumeGomez:search-result-title,… 

    … r=jyn514

Improve the page title switch handling between search and doc

The current behavior often "forgets" to update the page title when discarding/putting back the search results. This isn't optimal which is why I wrote this fix.

r? `@jyn514`
    @GuillaumeGomez
    GuillaumeGomez authored Nov 12, 2020
    Configuration menu
    Copy the full SHA
    7b25abf View commit details
    Browse the repository at this point in the history

  6. Rollup merge of rust-lang#78933 - jyn514:tracing-output, r=oli-obk 

    Don't print thread ids and names in `tracing` logs

Before:

```
2:rustc INFO rustc_interface::passes Pre-codegen
2:rustcTy interner             total           ty lt ct all
2:rustc    Adt               :   1078 81.3%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Array             :      1  0.1%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Slice             :      1  0.1%,  0.0%   0.0%  0.0%  0.0%
2:rustc    RawPtr            :      2  0.2%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Ref               :      4  0.3%,  0.1%   0.1%  0.0%  0.0%
2:rustc    FnDef             :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    FnPtr             :     76  5.7%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Placeholder       :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Generator         :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    GeneratorWitness  :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Dynamic           :      3  0.2%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Closure           :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Tuple             :     13  1.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Bound             :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Param             :    146 11.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Infer             :      2  0.2%,  0.1%   0.0%  0.0%  0.0%
2:rustc    Projection        :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Opaque            :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc    Foreign           :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
2:rustc                  total   1326         0.2%   0.1%  0.0%  0.0%
2:rustcInternalSubsts interner: rust-lang#437
2:rustcRegion interner: rust-lang#355
2:rustcStability interner: #1
2:rustcConst Stability interner: #0
2:rustcAllocation interner: #0
2:rustcLayout interner: #0
```

After:

```
 INFO rustc_interface::passes Post-codegen
Ty interner             total           ty lt ct all
    Adt               :   1078 81.3%,  0.0%   0.0%  0.0%  0.0%
    Array             :      1  0.1%,  0.0%   0.0%  0.0%  0.0%
    Slice             :      1  0.1%,  0.0%   0.0%  0.0%  0.0%
    RawPtr            :      2  0.2%,  0.0%   0.0%  0.0%  0.0%
    Ref               :      4  0.3%,  0.1%   0.1%  0.0%  0.0%
    FnDef             :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
    FnPtr             :     76  5.7%,  0.0%   0.0%  0.0%  0.0%
    Placeholder       :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
    Generator         :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
    GeneratorWitness  :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
    Dynamic           :      3  0.2%,  0.0%   0.0%  0.0%  0.0%
    Closure           :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
    Tuple             :     13  1.0%,  0.0%   0.0%  0.0%  0.0%
    Bound             :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
    Param             :    146 11.0%,  0.0%   0.0%  0.0%  0.0%
    Infer             :      2  0.2%,  0.1%   0.0%  0.0%  0.0%
    Projection        :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
    Opaque            :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
    Foreign           :      0  0.0%,  0.0%   0.0%  0.0%  0.0%
                  total   1326         0.2%   0.1%  0.0%  0.0%
InternalSubsts interner: rust-lang#437
Region interner: rust-lang#355
Stability interner: #1
Const Stability interner: #0
Allocation interner: #0
Layout interner: #0
```

Closes rust-lang#78931
r? `@oli-obk`
    @GuillaumeGomez
    GuillaumeGomez authored Nov 12, 2020
    Configuration menu
    Copy the full SHA
    9e28eb9 View commit details
    Browse the repository at this point in the history

  7. Rollup merge of rust-lang#78960 - ethanboxx:const-gen-test-default-er… 

    …ror, r=lcnr

Test default values for const parameters.

The last topic on rust-lang#78433

I originally intended to place these tests in a single file, however, due to them being parser errors that are fatal, they must be in separate files to be detected.

Thanks, `@lcnr` for mentoring me on this PR.

r? `@lcnr`
    @GuillaumeGomez
    GuillaumeGomez authored Nov 12, 2020
    Configuration menu
    Copy the full SHA
    4ada95f View commit details
    Browse the repository at this point in the history

  8. Rollup merge of rust-lang#78971 - ehuss:update-books, r=ehuss 

    Update books

## nomicon

8 commits in 69333eddb1de92fd17e272ce4677cc983d3bd71d..23c49f1d5ce4720bc5b7e3a920f47eccc8da6b63
2020-10-17 15:44:12 -0700 to 2020-11-05 13:30:53 +0900
-  (rust-lang/nomicon#238)
- Some tweaks (rust-lang/nomicon#244)
-  (rust-lang/nomicon#245)
- Update atomics.md (rust-lang/nomicon#224)
- Update send-and-sync.md (rust-lang/nomicon#187)
- fix a typo (rust-lang/nomicon#231)
- Improve formatting of "Transmutes" chapter (rust-lang/nomicon#242)
- Merge pull request rust-lang/nomicon#241 from simon-lammes/patch-1

## reference

4 commits in 10c16caebe475d0d11bec0531b95d7697856c13c..a7de763c213292f5b44bf10acb87ffa38724814d
2020-10-25 20:51:26 -0700 to 2020-11-11 19:13:21 -0800
- Referencify tuples (rust-lang/reference#899)
- Mention Box's partial field moves (rust-lang/reference#837)
- Enable triagebot (rust-lang/reference#862)
- Update deprecated GitHub Actions commands. (rust-lang/reference#896)

## rust-by-example

1 commits in 99eafee0cb14e6ec641bf02a69d7b30f6058349a..1886fda6981b723e4de637074455558f8bc1e83c
2020-10-21 14:21:55 -0300 to 2020-10-28 13:46:54 -0500
- Remove incorrect "lambda" terminology

## edition-guide

1 commits in 7bc9b7a5e800f79df62947cb7d566fd2fbaf19fe..b91a9a881ee007c12e74e844460ec407cf07a50f
2020-10-23 18:31:23 -0500 to 2020-11-02 11:02:03 -0600
- Clarify slice patterns example (rust-lang/edition-guide#223)
    @GuillaumeGomez
    GuillaumeGomez authored Nov 12, 2020
    Configuration menu
    Copy the full SHA
    4d0f068 View commit details
    Browse the repository at this point in the history