-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enclave TCS control #78772
Enclave TCS control #78772
Conversation
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
2be7bd8
to
d4fdbfc
Compare
Blocked by fortanix/rust-sgx#300 |
☔ The latest upstream changes (presumably #79128) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
|
Review can be delegated to me |
This comment has been minimized.
This comment has been minimized.
3218edc
to
5905f39
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #85014) made this pull request unmergeable. Please resolve the merge conflicts. |
5905f39
to
df7a9bd
Compare
df7a9bd
to
b83f5ac
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
☔ The latest upstream changes (presumably #90188) made this pull request unmergeable. Please resolve the merge conflicts. |
@@ -1,55 +1,55 @@ | |||
# This is based on https://github.com/japaric/rust-everywhere/blob/master/appveyor.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these changes?
I'm going to go ahead and close this PR, but please feel free to reopen or re-file when the upstream blocking concerns are addressed. Thanks! |
Intel SGXv2 enables the dynamic creation of TCSes. To use this correctly, the enclave needs to be in charge of controlling which TCS will be used for new threads. This PR implements such control for SGXv1 enclaves, as a preliminary step for SGXv2 support.
cc: @jethrogb