-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix intra-docs link in core::ffi::VaList #77784
Merged
bors
merged 1 commit into
rust-lang:master
from
aDotInTheVoid:ffi-sealed_trait-intra-docs
Oct 12, 2020
Merged
Fix intra-docs link in core::ffi::VaList #77784
bors
merged 1 commit into
rust-lang:master
from
aDotInTheVoid:ffi-sealed_trait-intra-docs
Oct 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 10, 2020
aDotInTheVoid
changed the title
Fix intra-docs link
Fix intra-docs link in core::ffi::VaList
Oct 10, 2020
@bors r+ rollup |
📌 Commit d5b7143 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 11, 2020
jyn514
added
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
A-intra-doc-links
Area: Intra-doc links, the ability to link to items in docs by name
labels
Oct 11, 2020
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 12, 2020
…a-docs, r=jyn514 Fix intra-docs link in core::ffi::VaList At some point, `VaList` was changes to be a [wrapper](https://github.com/rust-lang/rust/blob/1661f77/library/core/src/ffi.rs#L177-L201) over `VaListImpl`, and now the `Arg` method exists on [`VaListImpl`](https://github.com/rust-lang/rust/blob/1661f77/library/core/src/ffi.rs#L333-L336). This PR fixes the intradoc links so that when `--document-private-items` is ran on std (via [patch](https://gist.github.com/aDotInTheVoid/42c82306210203f9c9093c952b765ab4)), it works
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 12, 2020
…a-docs, r=jyn514 Fix intra-docs link in core::ffi::VaList At some point, `VaList` was changes to be a [wrapper](https://github.com/rust-lang/rust/blob/1661f77/library/core/src/ffi.rs#L177-L201) over `VaListImpl`, and now the `Arg` method exists on [`VaListImpl`](https://github.com/rust-lang/rust/blob/1661f77/library/core/src/ffi.rs#L333-L336). This PR fixes the intradoc links so that when `--document-private-items` is ran on std (via [patch](https://gist.github.com/aDotInTheVoid/42c82306210203f9c9093c952b765ab4)), it works
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 12, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#77550 (add shims for WithOptConstParam query calls) - rust-lang#77699 (Add word wrap for short descriptions) - rust-lang#77724 (Implement `AsRawFd` for `StdinLock` etc. on WASI.) - rust-lang#77746 (Fix `x.py setup` sets `changelog-seen`) - rust-lang#77784 (Fix intra-docs link in core::ffi::VaList) - rust-lang#77811 (rustdoc: Make some functions private that don't need to be public) - rust-lang#77818 (Mono collector: replace pair of ints with Range) - rust-lang#77831 (Use std methods on char instead of open coding them) - rust-lang#77852 (update url in bootstrap README (gcc-rs -> cc-rs)) - rust-lang#77863 (Remove `mark-i-m` from rustc-dev-guide maintainers) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-intra-doc-links
Area: Intra-doc links, the ability to link to items in docs by name
F-c_variadic
`#![feature(c_variadic)]`
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point,
VaList
was changes to be a wrapper overVaListImpl
, and now theArg
method exists onVaListImpl
. This PR fixes the intradoc links so that when--document-private-items
is ran on std (via patch), it works