Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use YAML anchors for try builds #77294

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Use YAML anchors for try builds #77294

merged 2 commits into from
Sep 30, 2020

Conversation

shepmaster
Copy link
Member

@shepmaster
Move the try builder below the auto builders
9da1582 
This allows us to make use of a YAML anchor when specifying the try
builder config.
@shepmaster
Use an anchor for the try build
630e353
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 28, 2020
@shepmaster
Copy link
Member Author

I recommend reviewing this with a tool that shows moves in addition to removes/additions.

@jyn514 jyn514 added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 28, 2020
@pietroalbini
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 29, 2020

📌 Commit 630e353 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2020
@bors
Copy link
Contributor

bors commented Sep 30, 2020

⌛ Testing commit 630e353 with merge 12f667f...

@bors
Copy link
Contributor

bors commented Sep 30, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: pietroalbini
Pushing 12f667f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 30, 2020
@bors bors merged commit 12f667f into rust-lang:master Sep 30, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 30, 2020
This was referenced Sep 30, 2020
Closed
Merged
@shepmaster shepmaster deleted the try-anchors branch September 30, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pietroalbini pietroalbini

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
6 participants
@shepmaster @pietroalbini @bors @rust-highfive @jyn514 @rustbot